drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-5337) OpenTSDB storage plugin
Date Thu, 02 Nov 2017 15:32:03 GMT

    [ https://issues.apache.org/jira/browse/DRILL-5337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16235945#comment-16235945
] 

ASF GitHub Bot commented on DRILL-5337:
---------------------------------------

Github user Vlad-Storona commented on a diff in the pull request:

    https://github.com/apache/drill/pull/774#discussion_r148568965
  
    --- Diff: contrib/storage-opentsdb/src/main/java/org/apache/drill/exec/store/openTSDB/client/services/ServiceImpl.java
---
    @@ -0,0 +1,176 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.drill.exec.store.openTSDB.client.services;
    +
    +import org.apache.drill.exec.store.openTSDB.client.OpenTSDB;
    +import org.apache.drill.exec.store.openTSDB.client.OpenTSDBTypes;
    +import org.apache.drill.exec.store.openTSDB.client.Service;
    +import org.apache.drill.exec.store.openTSDB.client.query.DBQuery;
    +import org.apache.drill.exec.store.openTSDB.client.query.Query;
    +import org.apache.drill.exec.store.openTSDB.dto.ColumnDTO;
    +import org.apache.drill.exec.store.openTSDB.dto.MetricDTO;
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +import retrofit2.Retrofit;
    +import retrofit2.converter.jackson.JacksonConverterFactory;
    +
    +import java.io.IOException;
    +import java.util.ArrayList;
    +import java.util.Collections;
    +import java.util.HashMap;
    +import java.util.HashSet;
    +import java.util.List;
    +import java.util.Map;
    +import java.util.Set;
    +
    +import static org.apache.drill.exec.store.openTSDB.Constants.AGGREGATOR;
    +import static org.apache.drill.exec.store.openTSDB.Constants.DOWNSAMPLE;
    +import static org.apache.drill.exec.store.openTSDB.Constants.METRIC;
    +import static org.apache.drill.exec.store.openTSDB.Util.isTableNameValid;
    +import static org.apache.drill.exec.store.openTSDB.Util.parseFROMRowData;
    +
    +public class ServiceImpl implements Service {
    +
    +  private static final Logger log =
    +      LoggerFactory.getLogger(ServiceImpl.class);
    +
    +  private OpenTSDB client;
    +  private Map<String, String> queryParameters;
    +
    +  public ServiceImpl(String connectionURL) {
    +    this.client = new Retrofit.Builder()
    +        .baseUrl(connectionURL)
    +        .addConverterFactory(JacksonConverterFactory.create())
    +        .build()
    +        .create(OpenTSDB.class);
    +  }
    +
    +  @Override
    +  public Set<MetricDTO> getTablesFromDB() {
    +    return getAllMetricsByTags();
    +  }
    +
    +  @Override
    +  public Set<String> getAllTableNames() {
    +    return getTableNames();
    +  }
    +
    +  @Override
    +  public List<ColumnDTO> getUnfixedColumnsToSchema() {
    +    Set<MetricDTO> tables = getAllMetricsByTags();
    +    List<ColumnDTO> unfixedColumns = new ArrayList<>();
    +
    +    for (MetricDTO table : tables) {
    +      for (String tag : table.getTags().keySet()) {
    +        ColumnDTO tmp = new ColumnDTO(tag, OpenTSDBTypes.STRING);
    +        if (!unfixedColumns.contains(tmp)) {
    +          unfixedColumns.add(tmp);
    +        }
    +      }
    +    }
    +    return unfixedColumns;
    +  }
    +
    +  @Override
    +  public void setupQueryParameters(String rowData) {
    +    if (!isTableNameValid(rowData)) {
    +      this.queryParameters = parseFROMRowData(rowData);
    +    } else {
    +      Map<String, String> params = new HashMap<>();
    +      params.put(METRIC, rowData);
    +      this.queryParameters = params;
    +    }
    +  }
    +
    +  private Set<MetricDTO> getAllMetricsByTags() {
    +    try {
    +      return getAllMetricsFromDBByTags();
    +    } catch (IOException e) {
    +      logIOException(e);
    --- End diff --
    
    No, it is the critical exception. I will add exception throwing with the detailed message.


> OpenTSDB storage plugin
> -----------------------
>
>                 Key: DRILL-5337
>                 URL: https://issues.apache.org/jira/browse/DRILL-5337
>             Project: Apache Drill
>          Issue Type: New Feature
>          Components: Storage - Other
>            Reporter: Dmitriy Gavrilovych
>            Assignee: Dmitriy Gavrilovych
>            Priority: Major
>              Labels: features
>             Fix For: 1.12.0
>
>
> Storage plugin for OpenTSDB
> The plugin uses REST API to work with TSDB. 
> Expected queries are listed below:
> SELECT * FROM openTSDB.`warp.speed.test`;
> Return all elements from warp.speed.test table with default aggregator SUM
> SELECT * FROM openTSDB.`(metric=warp.speed.test)`;
> Return all elements from (metric=warp.speed.test) table as a previous query, but with
alternative FROM syntax
> SELECT * FROM openTSDB.`(metric=warp.speed.test, aggregator=avg)`;
> Return all elements from warp.speed.test table, but with the custom aggregator
> SELECT `timestamp`, sum(`aggregated value`) FROM openTSDB.`(metric=warp.speed.test, aggregator=avg)`
GROUP BY `timestamp`;
> Return aggregated and grouped value by standard drill functions from warp.speed.test
table, but with the custom aggregator
> SELECT * FROM openTSDB.`(metric=warp.speed.test, downsample=5m-avg)`
> Return data limited by downsample



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message