drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-5089) Skip initializing all enabled storage plugins for every query
Date Fri, 17 Nov 2017 17:11:01 GMT

    [ https://issues.apache.org/jira/browse/DRILL-5089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16257237#comment-16257237
] 

ASF GitHub Bot commented on DRILL-5089:
---------------------------------------

Github user arina-ielchiieva commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1032#discussion_r151714418
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/FileSystemSchemaFactory.java
---
    @@ -50,11 +53,23 @@
     
       public static final String DEFAULT_WS_NAME = "default";
     
    +  public static final String LOCAL_FS_SCHEME = "file";
    +
       private List<WorkspaceSchemaFactory> factories;
       private String schemaName;
    +  protected FileSystemPlugin plugin;
     
       public FileSystemSchemaFactory(String schemaName, List<WorkspaceSchemaFactory>
factories) {
    -    super();
    +    // when the correspondent FileSystemPlugin is not passed in, we dig into ANY workspace
factory to get it.
    +    if (factories.size() > 0 ) {
    --- End diff --
    
    Please remove space `if (factories.size() > 0) {`.


> Skip initializing all enabled storage plugins for every query
> -------------------------------------------------------------
>
>                 Key: DRILL-5089
>                 URL: https://issues.apache.org/jira/browse/DRILL-5089
>             Project: Apache Drill
>          Issue Type: Improvement
>          Components: Query Planning & Optimization
>    Affects Versions: 1.9.0
>            Reporter: Abhishek Girish
>            Assignee: Chunhui Shi
>            Priority: Critical
>
> In a query's lifecycle, at attempt is made to initialize each enabled storage plugin,
while building the schema tree. This is done regardless of the actual plugins involved within
a query. 
> Sometimes, when one or more of the enabled storage plugins have issues - either due to
misconfiguration or the underlying datasource being slow or being down, the overall query
time taken increases drastically. Most likely due the attempt being made to register schemas
from a faulty plugin.
> For example, when a jdbc plugin is configured with SQL Server, and at one point the underlying
SQL Server db goes down, any Drill query starting to execute at that point and beyond begin
to slow down drastically. 
> We must skip registering unrelated schemas (& workspaces) for a query. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message