drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-4286) Have an ability to put server in quiescent mode of operation
Date Tue, 14 Nov 2017 22:42:06 GMT

    [ https://issues.apache.org/jira/browse/DRILL-4286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16252574#comment-16252574
] 

ASF GitHub Bot commented on DRILL-4286:
---------------------------------------

Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/921#discussion_r150973540
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/Drillbit.java ---
    @@ -176,18 +200,37 @@ public void run() throws Exception {
         logger.info("Startup completed ({} ms).", w.elapsed(TimeUnit.MILLISECONDS));
       }
     
    +  /*
    +    Wait uninterruptibly
    +   */
    +  public void waitForGracePeriod() {
    +    ExtendedLatch exitLatch = null;
    +    exitLatch = new ExtendedLatch();
    +    exitLatch.awaitUninterruptibly(gracePeriod);
    --- End diff --
    
    I wonder about synchronization. This latch is private, so never triggered, except in a
timeout. How is this different than `Thread.sleep()`, other than blocking interrupts? If so,
maybe a comment to this effect.
    
    Note also that this is called from inside a synchronized block. Just want to verify that
this is the intent.


> Have an ability to put server in quiescent mode of operation
> ------------------------------------------------------------
>
>                 Key: DRILL-4286
>                 URL: https://issues.apache.org/jira/browse/DRILL-4286
>             Project: Apache Drill
>          Issue Type: New Feature
>          Components: Execution - Flow
>            Reporter: Victoria Markman
>            Assignee: Venkata Jyothsna Donapati
>
> I think drill will benefit from mode of operation that is called "quiescent" in some
databases. 
> From IBM Informix server documentation:
> {code}
> Change gracefully from online to quiescent mode
> Take the database server gracefully from online mode to quiescent mode to restrict access
to the database server without interrupting current processing. After you perform this task,
the database server sets a flag that prevents new sessions from gaining access to the database
server. The current sessions are allowed to finish processing. After you initiate the mode
change, it cannot be canceled. During the mode change from online to quiescent, the database
server is considered to be in Shutdown mode.
> {code}
> This is different from shutdown, when processes are terminated. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message