drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-4286) Have an ability to put server in quiescent mode of operation
Date Fri, 03 Nov 2017 19:38:06 GMT

    [ https://issues.apache.org/jira/browse/DRILL-4286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16238260#comment-16238260

ASF GitHub Bot commented on DRILL-4286:

Github user bitblender commented on a diff in the pull request:

    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/Drillbit.java ---
    @@ -69,14 +73,30 @@
       public final static String SYSTEM_OPTIONS_NAME = "org.apache.drill.exec.server.Drillbit.system_options";
    -  private boolean isClosed = false;
       private final ClusterCoordinator coord;
       private final ServiceEngine engine;
       private final PersistentStoreProvider storeProvider;
       private final WorkManager manager;
       private final BootStrapContext context;
       private final WebServer webServer;
    +  private final int gracePeriod;
    +  private DrillbitStateManager stateManager;
    +  public void setQuiescentMode(boolean quiescentMode) {
    +    this.quiescentMode = quiescentMode;
    +  }
    +  private volatile boolean quiescentMode;
    +  public void setForceful_shutdown(boolean forceful_shutdown) {
    +    this.forceful_shutdown = forceful_shutdown;
    +  }
    +  private volatile boolean forceful_shutdown = false;
    --- End diff --
    any reason why you did not camel-case this variable? 

> Have an ability to put server in quiescent mode of operation
> ------------------------------------------------------------
>                 Key: DRILL-4286
>                 URL: https://issues.apache.org/jira/browse/DRILL-4286
>             Project: Apache Drill
>          Issue Type: New Feature
>          Components: Execution - Flow
>            Reporter: Victoria Markman
>            Assignee: Venkata Jyothsna Donapati
>            Priority: Major
> I think drill will benefit from mode of operation that is called "quiescent" in some
> From IBM Informix server documentation:
> {code}
> Change gracefully from online to quiescent mode
> Take the database server gracefully from online mode to quiescent mode to restrict access
to the database server without interrupting current processing. After you perform this task,
the database server sets a flag that prevents new sessions from gaining access to the database
server. The current sessions are allowed to finish processing. After you initiate the mode
change, it cannot be canceled. During the mode change from online to quiescent, the database
server is considered to be in Shutdown mode.
> {code}
> This is different from shutdown, when processes are terminated. 

This message was sent by Atlassian JIRA

View raw message