drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-3640) Drill JDBC driver support Statement.setQueryTimeout(int)
Date Wed, 08 Nov 2017 00:49:03 GMT

    [ https://issues.apache.org/jira/browse/DRILL-3640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16243187#comment-16243187
] 

ASF GitHub Bot commented on DRILL-3640:
---------------------------------------

Github user kkhatua commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1024#discussion_r149548759
  
    --- Diff: exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillCursor.java ---
    @@ -333,8 +368,14 @@ void close() {
         final int batchQueueThrottlingThreshold =
             client.getConfig().getInt(
                 ExecConstants.JDBC_BATCH_QUEUE_THROTTLING_THRESHOLD );
    -    resultsListener = new ResultsListener(batchQueueThrottlingThreshold);
    +    resultsListener = new ResultsListener(this, batchQueueThrottlingThreshold);
         currentBatchHolder = new RecordBatchLoader(client.getAllocator());
    +    try {
    +      setTimeout(this.statement.getQueryTimeout());
    +    } catch (SQLException e) {
    +      // Printing any unexpected SQLException stack trace
    +      e.printStackTrace();
    --- End diff --
    
    I agree. Thankfully, the _caller_ does handle any thrown `SQLException`s, so I'm going
to pass this off to that. IMO, I don't think we'll have an issue because the `Statement.setQueryTimeout()`
would have handled any corner cases before this is invoked via `execute()`


> Drill JDBC driver support Statement.setQueryTimeout(int)
> --------------------------------------------------------
>
>                 Key: DRILL-3640
>                 URL: https://issues.apache.org/jira/browse/DRILL-3640
>             Project: Apache Drill
>          Issue Type: New Feature
>          Components: Client - JDBC
>    Affects Versions: 1.2.0
>            Reporter: Chun Chang
>            Assignee: Kunal Khatua
>             Fix For: 1.12.0
>
>
> It would be nice if we have this implemented. Run away queries can be automatically canceled
by setting the timeout. 
> java.sql.SQLFeatureNotSupportedException: Setting network timeout is not supported.
> 	at org.apache.drill.jdbc.impl.DrillStatementImpl.setQueryTimeout(DrillStatementImpl.java:152)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message