Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 7BB87200D2F for ; Wed, 18 Oct 2017 07:23:05 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 7A3A21609EC; Wed, 18 Oct 2017 05:23:05 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id BFE671609EB for ; Wed, 18 Oct 2017 07:23:04 +0200 (CEST) Received: (qmail 11009 invoked by uid 500); 18 Oct 2017 05:23:03 -0000 Mailing-List: contact issues-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list issues@drill.apache.org Received: (qmail 10999 invoked by uid 99); 18 Oct 2017 05:23:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 18 Oct 2017 05:23:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id C06221A173E for ; Wed, 18 Oct 2017 05:23:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id 3-jD_-TMuSv6 for ; Wed, 18 Oct 2017 05:23:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 1A34B5FAC9 for ; Wed, 18 Oct 2017 05:23:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 544CBE00B3 for ; Wed, 18 Oct 2017 05:23:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 0946024360 for ; Wed, 18 Oct 2017 05:23:00 +0000 (UTC) Date: Wed, 18 Oct 2017 05:23:00 +0000 (UTC) From: "Sorabh Hamirwasia (JIRA)" To: issues@drill.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (DRILL-5881) Java Client: [Threat Modeling] Drillbit may be spoofed by an attacker and this may lead to data being written to the attacker's target instead of Drillbit MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 18 Oct 2017 05:23:05 -0000 [ https://issues.apache.org/jira/browse/DRILL-5881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16208829#comment-16208829 ] Sorabh Hamirwasia commented on DRILL-5881: ------------------------------------------ This change introduces stricter checks on client side for security negotiation between client and Drillbit. Before this patch Drillbit was dictating to client side if it needs authentication or not and client was abiding with that. But with this PR we are checking for indication from client connection URL if it needs the underlying connection to be secure or not. If client needs secure connection and Drillbit is not configured for security then client will fail the connection. This is a change in behavior w.r.t current functionality, since with the presence of username&password in connection URL now DrillClient will take that as an indication for authenticated connection request and if server doesn't support authentication then DrillClient connection will fail. Whereas currently if server is not secured then the username and password is ignored. So with this patch any client connection URL which has username&password in it and trying to connect to unsecure cluster will fail. > Java Client: [Threat Modeling] Drillbit may be spoofed by an attacker and this may lead to data being written to the attacker's target instead of Drillbit > ---------------------------------------------------------------------------------------------------------------------------------------------------------- > > Key: DRILL-5881 > URL: https://issues.apache.org/jira/browse/DRILL-5881 > Project: Apache Drill > Issue Type: Sub-task > Components: Client - Java > Affects Versions: 1.10.0 > Reporter: Sorabh Hamirwasia > Assignee: Sorabh Hamirwasia > Fix For: 1.12.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)