Mailing-List: contact issues-help@drill.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@drill.apache.org
Date: Thu, 12 Oct 2017 13:23:00 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@drill.apache.org
Message-ID: <JIRA.13102167.1505376201000.40125.1507814580166@Atlassian.JIRA>
In-Reply-To: <JIRA.13102167.1505376201000@Atlassian.JIRA>
References: <JIRA.13102167.1505376201000@Atlassian.JIRA> <JIRA.13102167.1505376201751@jira-lw-us.apache.org>
Subject: [jira] [Commented] (DRILL-5790) PCAP format explicitly opens local
 file
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Thu, 12 Oct 2017 13:23:07 -0000


    [ https://issues.apache.org/jira/browse/DRILL-5790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16201924#comment-16201924 ] 

ASF GitHub Bot commented on DRILL-5790:
---------------------------------------

Github user Vlad-Storona commented on a diff in the pull request:

    https://github.com/apache/drill/pull/989#discussion_r144286706
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/pcap/PcapRecordReader.java ---
    @@ -100,14 +104,14 @@ public void setup(final OperatorContext context, final OutputMutator output) thr
     
           this.output = output;
           this.buffer = new byte[100000];
    -      this.in = new FileInputStream(inputPath);
    +      this.in = fs.open(pathToFile);
           this.decoder = new PacketDecoder(in);
           this.validBytes = in.read(buffer);
           this.projectedCols = getProjectedColsIfItNull();
           setColumns(projectedColumns);
         } catch (IOException io) {
           throw UserException.dataReadError(io)
    -          .addContext("File name:", inputPath)
    +          .addContext("File name:", pathToFile.toString())
    --- End diff --
    
    Thanks, I will replace it.


> PCAP format explicitly opens local file
> ---------------------------------------
>
>                 Key: DRILL-5790
>                 URL: https://issues.apache.org/jira/browse/DRILL-5790
>             Project: Apache Drill
>          Issue Type: Bug
>    Affects Versions: 1.11.0
>            Reporter: Ted Dunning
>             Fix For: 1.12.0
>
>
> Note the new FileInputStream line
> {code}
> @Override
> public void setup(final OperatorContext context, final OutputMutator output) throws ExecutionSetupException {
>     try {
>         this.output = output;
>         this.buffer = new byte[100000];
>         this.in = new FileInputStream(inputPath);
>         this.decoder = new PacketDecoder(in);
>         this.validBytes = in.read(buffer);
>         this.projectedCols = getProjectedColsIfItNull();
>         setColumns(projectedColumns);
>     } catch (IOException io) {
>         throw UserException.dataReadError(io)
> 	    .addContext("File name:", inputPath)
> 	    .build(logger);
>     }
> }
> {code}


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)