Mailing-List: contact issues-help@drill.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@drill.apache.org
Date: Wed, 25 Oct 2017 22:56:02 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@drill.apache.org
Message-ID: <JIRA.13101735.1505242095000.62728.1508972162005@Atlassian.JIRA>
In-Reply-To: <JIRA.13101735.1505242095000@Atlassian.JIRA>
References: <JIRA.13101735.1505242095000@Atlassian.JIRA> <JIRA.13101735.1505242095545@jira-lw-us.apache.org>
Subject: [jira] [Commented] (DRILL-5783) Make code generation in the TopN
 operator more modular and test it
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Wed, 25 Oct 2017 22:56:09 -0000


    [ https://issues.apache.org/jira/browse/DRILL-5783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16219695#comment-16219695 ] 

ASF GitHub Bot commented on DRILL-5783:
---------------------------------------

Github user ilooner commented on a diff in the pull request:

    https://github.com/apache/drill/pull/984#discussion_r147008923
  
    --- Diff: exec/java-exec/src/test/java/org/apache/drill/TestCTASPartitionFilter.java ---
    @@ -59,48 +58,48 @@ public void withDistribution() throws Exception {
         test("alter session set `planner.slice_target` = 1");
         test("alter session set `store.partition.hash_distribute` = true");
         test("use dfs_test.tmp");
    -    test(String.format("create table orders_distribution partition by (o_orderpriority) as select * from dfs_test.`%s/multilevel/parquet`", TEST_RES_PATH));
    +    test("create table orders_distribution partition by (o_orderpriority) as select * from dfs_test.`/multilevel/parquet`");
         String query = "select * from orders_distribution where o_orderpriority = '1-URGENT'";
    -    testExcludeFilter(query, 1, "Filter", 24);
    +    testExcludeFilter(query, 1, "Filter\\(", 24);
    --- End diff --
    
    It is no longer sufficient to match "Filter" because the test class name contains "Filter" and the test class name is used to create the tmp directory. And the fully qualified path of a queried file is included in the plan. We want to only match the <b>Filter</b> steps generated in the plan, not the <b>Filters</b> in our file paths. In order to do this I tell it to match "Filter(" which corresponds to a filter step in the plan.


> Make code generation in the TopN operator more modular and test it
> ------------------------------------------------------------------
>
>                 Key: DRILL-5783
>                 URL: https://issues.apache.org/jira/browse/DRILL-5783
>             Project: Apache Drill
>          Issue Type: Improvement
>            Reporter: Timothy Farkas
>            Assignee: Timothy Farkas
>


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)