drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-5896) Handle vector creation in HbaseRecordReader to avoid NullableInt vectors later
Date Thu, 26 Oct 2017 04:13:01 GMT

    [ https://issues.apache.org/jira/browse/DRILL-5896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16219953#comment-16219953
] 

ASF GitHub Bot commented on DRILL-5896:
---------------------------------------

Github user prasadns14 commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1005#discussion_r147042366
  
    --- Diff: contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/HBaseRecordReader.java
---
    @@ -121,16 +125,18 @@ public HBaseRecordReader(Connection connection, HBaseSubScan.HBaseSubScanSpec
su
             byte[] family = root.getPath().getBytes();
             transformed.add(SchemaPath.getSimplePath(root.getPath()));
             PathSegment child = root.getChild();
    -        if (!completeFamilies.contains(new String(family, StandardCharsets.UTF_8).toLowerCase()))
{
    -          if (child != null && child.isNamed()) {
    -            byte[] qualifier = child.getNameSegment().getPath().getBytes();
    +        if (child != null && child.isNamed()) {
    +          byte[] qualifier = child.getNameSegment().getPath().getBytes();
    +          hbaseScan1.addColumn(family, qualifier);
    +          if (!completeFamilies.contains(new String(family, StandardCharsets.UTF_8)))
{
    --- End diff --
    
    Fixed


> Handle vector creation in HbaseRecordReader to avoid NullableInt vectors later
> ------------------------------------------------------------------------------
>
>                 Key: DRILL-5896
>                 URL: https://issues.apache.org/jira/browse/DRILL-5896
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Storage - HBase
>    Affects Versions: 1.11.0
>            Reporter: Prasad Nagaraj Subramanya
>            Assignee: Prasad Nagaraj Subramanya
>             Fix For: 1.12.0
>
>
> When a hbase query projects both a column family and a column in the column family, the
vector for the column is not created in the HbaseRecordReader.
> So, in cases where scan batch is empty we create a NullableInt vector for this column.
We need to handle column creation in the reader.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message