drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-5887) Display process user/ groups in Drill UI
Date Wed, 18 Oct 2017 23:37:00 GMT

    [ https://issues.apache.org/jira/browse/DRILL-5887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16210299#comment-16210299
] 

ASF GitHub Bot commented on DRILL-5887:
---------------------------------------

Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/998#discussion_r145569370
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/DrillRoot.java
---
    @@ -85,21 +86,33 @@ public ClusterInfo getClusterInfoJSON() {
         // For all other cases the user info need-not or should-not be displayed
         OptionManager optionManager = work.getContext().getOptionManager();
         final boolean isUserLoggedIn = AuthDynamicFeature.isUserLoggedIn(sc);
    +    final String processUser = isUserLoggedIn ?
    +            ImpersonationUtil.getProcessUserName() : null;
    +    final String processUserGroups = isUserLoggedIn ?
    +            Joiner.on(",").join(ImpersonationUtil.getProcessUserGroupNames()) : null;
    --- End diff --
    
    Are we guaranteed that the list contains no spaces around the commas? (When reading from
ZK, the string is user entered, and the string might be "fred   ,   bob". Do we have to worry
about that here?) If the string might contain extra spaces, we might want to use code that
Karthik provided to split, strip spaces, and combine the names.


> Display process user/ groups in Drill UI
> ----------------------------------------
>
>                 Key: DRILL-5887
>                 URL: https://issues.apache.org/jira/browse/DRILL-5887
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Client - HTTP
>    Affects Versions: 1.11.0
>            Reporter: Prasad Nagaraj Subramanya
>            Assignee: Prasad Nagaraj Subramanya
>            Priority: Minor
>             Fix For: 1.12.0
>
>
> Drill UI only lists admin user/ groups specified as options
> We should display the process user/ groups who have admin privilege



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message