drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Timothy Farkas (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-5841) Unit tests fail when unexpected files are in the tmp folder
Date Tue, 10 Oct 2017 04:37:00 GMT

    [ https://issues.apache.org/jira/browse/DRILL-5841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16198156#comment-16198156
] 

Timothy Farkas commented on DRILL-5841:
---------------------------------------

There are two things that need to be fixed.

# The unit tests should use isolated workspaces, not the global /tmp folder. Unit tests should
also use a uniform method for creating tmp files and directories. There are a variety of ways
(some of which are error prone) that unit tests are doing this now. I am bundling a fix for
this along with my PR for DRILL-5783. I am updating ALL the unit tests (yes all of them) to
use a standardized tmp workspace pattern. This will effectively prevent us from seeing issues
like the one reported here.

# The next issue is that there appears to be some incorrect behavior with DotDrillUtil which
is causing the bug I observed. I'm unsure how to fix this, and the unit test fix above will
prevent us from seeing this issue. Additionally no one else appears to be experiencing an
issue with this, so this is not high priority and I will not pursue this fix.

> Unit tests fail when unexpected files are in the tmp folder
> -----------------------------------------------------------
>
>                 Key: DRILL-5841
>                 URL: https://issues.apache.org/jira/browse/DRILL-5841
>             Project: Apache Drill
>          Issue Type: Bug
>            Reporter: Timothy Farkas
>            Assignee: Timothy Farkas
>            Priority: Minor
>
> My Mac creates wifi*.log files in the /tmp folder. This can cause some unit tests to
fail because Drill does not like finding unexpected files in the /tmp folder.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message