drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-5832) Migrate OperatorFixture to use SystemOptionManager rather than mock
Date Tue, 17 Oct 2017 18:07:08 GMT

    [ https://issues.apache.org/jira/browse/DRILL-5832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16208051#comment-16208051
] 

ASF GitHub Bot commented on DRILL-5832:
---------------------------------------

Github user paul-rogers commented on the issue:

    https://github.com/apache/drill/pull/970
  
    There is a funny thing about the way Drill works. I can review your changes and commit
them as soon as I provide a +1. My changes must wait until another committer to find time
in their very busy schedules to consider this work. So, we'll likely commit yours first, I'll
rebase mine on top of it, then wait for another committer to find time to consider it. The
one exception would be if a non-committer can give this PR a +1 and a committer agrees to
do a bulk commit this week.


> Migrate OperatorFixture to use SystemOptionManager rather than mock
> -------------------------------------------------------------------
>
>                 Key: DRILL-5832
>                 URL: https://issues.apache.org/jira/browse/DRILL-5832
>             Project: Apache Drill
>          Issue Type: Improvement
>    Affects Versions: 1.12.0
>            Reporter: Paul Rogers
>            Assignee: Paul Rogers
>             Fix For: 1.12.0
>
>
> The {{OperatorFixture}} provides structure for testing individual operators and other
"sub-operator" bits of code. To do that, the framework provides mock network-free and server-free
versions of the fragment context and operator context.
> As part of the mock, the {{OperatorFixture}} provides a mock version of the system option
manager that provides a simple test-only implementation of an option set.
> With the recent major changes to the system option manager, this mock implementation
has drifted out of sync with the system option manager. Rather than upgrading the mock implementation,
this ticket asks to use the system option manager directly -- but configured for no ZK or
file persistence of options.
> The key reason for this change is that the system option manager has implemented a sophisticated
way to handle option defaults; it is better to leverage that than to provide a mock implementation.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message