drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-5783) Make code generation in the TopN operator more modular and test it
Date Thu, 26 Oct 2017 20:26:00 GMT

    [ https://issues.apache.org/jira/browse/DRILL-5783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16221157#comment-16221157
] 

ASF GitHub Bot commented on DRILL-5783:
---------------------------------------

Github user ilooner commented on a diff in the pull request:

    https://github.com/apache/drill/pull/984#discussion_r147256621
  
    --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/xsort/TestSimpleExternalSort.java
---
    @@ -147,7 +152,7 @@ public void sortOneKeyDescendingExternalSortLegacy() throws Throwable
{
       }
     
       private void sortOneKeyDescendingExternalSort(boolean testLegacy) throws Throwable
{
    -    FixtureBuilder builder = ClusterFixture.builder()
    +    FixtureBuilder builder = ClusterFixture.builder(dirTestWatcher)
    --- End diff --
    
    Is there a case where the tmp directories are optional? The Drillbit will always have
to be configured with a <b>drill.tmp-dir</b> at minimum, so I think it should
be required to use a BaseDirTestWatcher with a ClusterFixture. I could move passing the dirTestWatcher
to the build method instead of the constructor. Let me know what you think.


> Make code generation in the TopN operator more modular and test it
> ------------------------------------------------------------------
>
>                 Key: DRILL-5783
>                 URL: https://issues.apache.org/jira/browse/DRILL-5783
>             Project: Apache Drill
>          Issue Type: Improvement
>            Reporter: Timothy Farkas
>            Assignee: Timothy Farkas
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message