drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-5783) Make code generation in the TopN operator more modular and test it
Date Wed, 25 Oct 2017 22:56:02 GMT

    [ https://issues.apache.org/jira/browse/DRILL-5783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16219695#comment-16219695

ASF GitHub Bot commented on DRILL-5783:

Github user ilooner commented on a diff in the pull request:

    --- Diff: exec/java-exec/src/test/java/org/apache/drill/TestCTASPartitionFilter.java ---
    @@ -59,48 +58,48 @@ public void withDistribution() throws Exception {
         test("alter session set `planner.slice_target` = 1");
         test("alter session set `store.partition.hash_distribute` = true");
         test("use dfs_test.tmp");
    -    test(String.format("create table orders_distribution partition by (o_orderpriority)
as select * from dfs_test.`%s/multilevel/parquet`", TEST_RES_PATH));
    +    test("create table orders_distribution partition by (o_orderpriority) as select *
from dfs_test.`/multilevel/parquet`");
         String query = "select * from orders_distribution where o_orderpriority = '1-URGENT'";
    -    testExcludeFilter(query, 1, "Filter", 24);
    +    testExcludeFilter(query, 1, "Filter\\(", 24);
    --- End diff --
    It is no longer sufficient to match "Filter" because the test class name contains "Filter"
and the test class name is used to create the tmp directory. And the fully qualified path
of a queried file is included in the plan. We want to only match the <b>Filter</b>
steps generated in the plan, not the <b>Filters</b> in our file paths. In order
to do this I tell it to match "Filter(" which corresponds to a filter step in the plan.

> Make code generation in the TopN operator more modular and test it
> ------------------------------------------------------------------
>                 Key: DRILL-5783
>                 URL: https://issues.apache.org/jira/browse/DRILL-5783
>             Project: Apache Drill
>          Issue Type: Improvement
>            Reporter: Timothy Farkas
>            Assignee: Timothy Farkas

This message was sent by Atlassian JIRA

View raw message