drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-5783) Make code generation in the TopN operator more modular and test it
Date Wed, 25 Oct 2017 22:49:00 GMT

    [ https://issues.apache.org/jira/browse/DRILL-5783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16219691#comment-16219691
] 

ASF GitHub Bot commented on DRILL-5783:
---------------------------------------

Github user ilooner commented on a diff in the pull request:

    https://github.com/apache/drill/pull/984#discussion_r147007663
  
    --- Diff: exec/java-exec/src/test/java/org/apache/drill/TestAltSortQueries.java ---
    @@ -19,24 +19,33 @@
     
     import org.apache.drill.categories.OperatorTest;
     import org.apache.drill.categories.SqlTest;
    +import org.apache.drill.test.BaseTestQuery;
    +import org.junit.BeforeClass;
     import org.junit.Test;
     import org.junit.experimental.categories.Category;
     
     @Category({SqlTest.class, OperatorTest.class})
    -public class TestAltSortQueries extends BaseTestQuery{
    +public class TestAltSortQueries extends BaseTestQuery {
       static final org.slf4j.Logger logger = org.slf4j.LoggerFactory.getLogger(TestAltSortQueries.class);
     
    +  @BeforeClass
    +  public static void setupTestFiles() {
    +    dirTestWatcher.copyFileToRoot("sample-data/region.parquet");
    +    dirTestWatcher.copyFileToRoot("sample-data/regionsSF");
    +    dirTestWatcher.copyFileToRoot("sample-data/nation.parquet");
    +  }
    +
       @Test
       public void testOrderBy() throws Exception{
         test("select R_REGIONKEY " +
    -         "from dfs_test.`[WORKING_PATH]/../../sample-data/region.parquet` " +
    +         "from dfs_test.`/sample-data/region.parquet` " +
    --- End diff --
    
    I have now removed **dfs_test** completely. There was no reason for it to be added and
it was inconsistently being mixed with **dfs**. The **dfs** workspaces are automatically mapped
to the correct temp directories for you provided that you use **BaseTestQuery** or the **ClusterFixture**.
I will update **org.apache.drill.test.package-info.java** with the theory of how this works
and will add a simple example to **ExampleTest.java**


> Make code generation in the TopN operator more modular and test it
> ------------------------------------------------------------------
>
>                 Key: DRILL-5783
>                 URL: https://issues.apache.org/jira/browse/DRILL-5783
>             Project: Apache Drill
>          Issue Type: Improvement
>            Reporter: Timothy Farkas
>            Assignee: Timothy Farkas
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message