drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-5783) Make code generation in the TopN operator more modular and test it
Date Thu, 12 Oct 2017 04:47:00 GMT

    [ https://issues.apache.org/jira/browse/DRILL-5783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16201430#comment-16201430
] 

ASF GitHub Bot commented on DRILL-5783:
---------------------------------------

Github user ilooner commented on a diff in the pull request:

    https://github.com/apache/drill/pull/984#discussion_r144193392
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/compile/CodeCompiler.java
---
    @@ -110,6 +109,11 @@ public CodeGenCompiler(final DrillConfig config, final OptionSet
optionManager)
       public static final String DISABLE_CACHE_CONFIG = COMPILE_BASE + ".disable_cache";
     
       /**
    +   * Enables saving generated code for debugging
    +   */
    +  public static final String ENABLE_SAVE_CODE_FOR_DEBUG = COMPILE_BASE + ".codegen.dump";
    --- End diff --
    
    The directory that generated code is dumped into is determined by the ClassBuilder.CODE_DIR_OPTION
property. The DirTestWatcher createw a directory of the following form:
    
    ```
    /target/<Fully qualified test class name>/<test method name>
    ```
    
    So if the ClassBuilder.CODE_DIR_OPTION property is configured to use the directory generated
by the DirTestWatcher, the code is dumped into the same well defined location every test run.
Also the generated class file has names like:
    
    ```
    <interface name>Gen<random num>.java
    ```


> Make code generation in the TopN operator more modular and test it
> ------------------------------------------------------------------
>
>                 Key: DRILL-5783
>                 URL: https://issues.apache.org/jira/browse/DRILL-5783
>             Project: Apache Drill
>          Issue Type: Improvement
>            Reporter: Timothy Farkas
>            Assignee: Timothy Farkas
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message