drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-5783) Make code generation in the TopN operator more modular and test it
Date Wed, 11 Oct 2017 23:49:01 GMT

    [ https://issues.apache.org/jira/browse/DRILL-5783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16201219#comment-16201219
] 

ASF GitHub Bot commented on DRILL-5783:
---------------------------------------

Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/984#discussion_r144131729
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/compile/CodeCompiler.java
---
    @@ -110,6 +109,11 @@ public CodeGenCompiler(final DrillConfig config, final OptionSet
optionManager)
       public static final String DISABLE_CACHE_CONFIG = COMPILE_BASE + ".disable_cache";
     
       /**
    +   * Enables saving generated code for debugging
    +   */
    +  public static final String ENABLE_SAVE_CODE_FOR_DEBUG = COMPILE_BASE + ".codegen.dump";
    --- End diff --
    
    When saving generated code, I have to point to the directory from Eclipse. This means
two things:
    
    1. It works best if the same directory is used from one run to the next. (That is, no
randomly generated temp directory.)
    2. The directory has to be visible to the Eclipse UI. (That is, no hidden directories
starting with dots.)
    
    Can we make the directory in a known location, and can we use a nice simple name like
"codegen"?


> Make code generation in the TopN operator more modular and test it
> ------------------------------------------------------------------
>
>                 Key: DRILL-5783
>                 URL: https://issues.apache.org/jira/browse/DRILL-5783
>             Project: Apache Drill
>          Issue Type: Improvement
>            Reporter: Timothy Farkas
>            Assignee: Timothy Farkas
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message