drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-5783) Make code generation in the TopN operator more modular and test it
Date Wed, 18 Oct 2017 22:37:00 GMT

    [ https://issues.apache.org/jira/browse/DRILL-5783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16210210#comment-16210210
] 

ASF GitHub Bot commented on DRILL-5783:
---------------------------------------

Github user julianhyde commented on a diff in the pull request:

    https://github.com/apache/drill/pull/984#discussion_r145561518
  
    --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/ClusterFixture.java ---
    @@ -584,11 +492,14 @@ public static void defineWorkspace(Drillbit drillbit, String pluginName,
       public static final String EXPLAIN_PLAN_TEXT = "text";
       public static final String EXPLAIN_PLAN_JSON = "json";
     
    -  public static FixtureBuilder builder() {
    -    FixtureBuilder builder = new FixtureBuilder()
    +  public static FixtureBuilder builder(DirTestWatcher dirTestWatcher) {
    --- End diff --
    
    Jeez Paul, please start a review rather than making single review comments. I just got
39 emails from you, and so did everyone else on dev@drill.


> Make code generation in the TopN operator more modular and test it
> ------------------------------------------------------------------
>
>                 Key: DRILL-5783
>                 URL: https://issues.apache.org/jira/browse/DRILL-5783
>             Project: Apache Drill
>          Issue Type: Improvement
>            Reporter: Timothy Farkas
>            Assignee: Timothy Farkas
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message