drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-5783) Make code generation in the TopN operator more modular and test it
Date Wed, 18 Oct 2017 22:36:00 GMT

    [ https://issues.apache.org/jira/browse/DRILL-5783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16210209#comment-16210209
] 

ASF GitHub Bot commented on DRILL-5783:
---------------------------------------

Github user ilooner-mapr commented on a diff in the pull request:

    https://github.com/apache/drill/pull/984#discussion_r145561373
  
    --- Diff: common/src/main/java/org/apache/drill/common/util/TestTools.java ---
    @@ -17,15 +17,28 @@
      */
     package org.apache.drill.common.util;
     
    +import java.io.File;
    +import java.io.IOException;
     import java.nio.file.Paths;
     
    +import org.apache.commons.io.FileUtils;
     import org.junit.rules.TestName;
     import org.junit.rules.TestRule;
     import org.junit.rules.Timeout;
     
    +import static org.apache.drill.common.util.TestTools.DataType.PROJECT;
    +import static org.apache.drill.common.util.TestTools.DataType.RESOURCE;
    +
     public class TestTools {
       // private static final org.slf4j.Logger logger = org.slf4j.LoggerFactory.getLogger(TestTools.class);
     
    +  public enum DataType {
    --- End diff --
    
    Done changed to FileSource


> Make code generation in the TopN operator more modular and test it
> ------------------------------------------------------------------
>
>                 Key: DRILL-5783
>                 URL: https://issues.apache.org/jira/browse/DRILL-5783
>             Project: Apache Drill
>          Issue Type: Improvement
>            Reporter: Timothy Farkas
>            Assignee: Timothy Farkas
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message