drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-5783) Make code generation in the TopN operator more modular and test it
Date Wed, 18 Oct 2017 22:24:05 GMT

    [ https://issues.apache.org/jira/browse/DRILL-5783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16210183#comment-16210183
] 

ASF GitHub Bot commented on DRILL-5783:
---------------------------------------

Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/984#discussion_r145522320
  
    --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/ExampleTest.java ---
    @@ -59,6 +59,9 @@
     @Ignore
     public class ExampleTest {
     
    +  @Rule
    +  public final DirTestWatcher dirTestWatcher = new DirTestWatcher();
    --- End diff --
    
    This is meant as an example, so perhaps include some Javadoc to explain what this is and
how to use it. Maybe explain how to use the temp directories, and include a new example test
below that illustrates the main points. People are busy, they don't often don't have time
to read documentation, but they often will copy & paste a good example...


> Make code generation in the TopN operator more modular and test it
> ------------------------------------------------------------------
>
>                 Key: DRILL-5783
>                 URL: https://issues.apache.org/jira/browse/DRILL-5783
>             Project: Apache Drill
>          Issue Type: Improvement
>            Reporter: Timothy Farkas
>            Assignee: Timothy Farkas
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message