drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-5717) change some date time unit cases with specific timezone or Local
Date Wed, 18 Oct 2017 16:07:00 GMT

    [ https://issues.apache.org/jira/browse/DRILL-5717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16209600#comment-16209600
] 

ASF GitHub Bot commented on DRILL-5717:
---------------------------------------

Github user vvysotskyi commented on the issue:

    https://github.com/apache/drill/pull/904
  
    @weijietong which problems did you have when tried to mock `System.getProperty()` method?
    As the example of nice mock of this method, you may use [this test](https://github.com/apache/drill/pull/936/files#diff-b053496903bff0dc154e42604b93b9efR60).
Also besides the timezone, property with locale should be mocked.


> change some date time unit cases with specific timezone or Local
> ----------------------------------------------------------------
>
>                 Key: DRILL-5717
>                 URL: https://issues.apache.org/jira/browse/DRILL-5717
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Tools, Build & Test
>    Affects Versions: 1.9.0, 1.11.0
>            Reporter: weijie.tong
>
> Some date time test cases like  JodaDateValidatorTest  is not Local independent .This
will cause other Local's users's test phase to fail. We should let these test cases to be
Local env independent.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message