drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-5431) Support SSL
Date Thu, 05 Oct 2017 01:09:01 GMT

    [ https://issues.apache.org/jira/browse/DRILL-5431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16192327#comment-16192327
] 

ASF GitHub Bot commented on DRILL-5431:
---------------------------------------

Github user parthchandra commented on a diff in the pull request:

    https://github.com/apache/drill/pull/950#discussion_r142827859
  
    --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/TestSSLConfig.java ---
    @@ -49,12 +64,19 @@ public void testMissingKeystorePassword() throws Exception {
         ConfigBuilder config = new ConfigBuilder();
         config.put(ExecConstants.HTTP_KEYSTORE_PATH, "/root");
         config.put(ExecConstants.HTTP_KEYSTORE_PASSWORD, "");
    +    config.put(ExecConstants.SSL_USE_HADOOP_CONF, false);
    +    config.put(ExecConstants.USER_SSL_ENABLED, true);
         try {
    -      SSLConfig sslv = new SSLConfig(config.build());
    +      SSLConfig sslv = new SSLConfigBuilder()
    +          .config(config.build())
    +          .mode(SSLFactory.Mode.SERVER)
    +          .initializeSSLContext(false)
    +          .validateKeyStore(true)
    +          .build();
           fail();
           //Expected
         } catch (Exception e) {
    -      assertTrue(e instanceof DrillException);
    +
    --- End diff --
    
    If the hadoop config is invalid the build method will throw an exception. So we are looking
to make sure the build method does, in fact, throw an exception. If it does the test passes,
otherwise it fails.


> Support SSL
> -----------
>
>                 Key: DRILL-5431
>                 URL: https://issues.apache.org/jira/browse/DRILL-5431
>             Project: Apache Drill
>          Issue Type: New Feature
>          Components: Client - Java, Client - ODBC
>            Reporter: Sudheesh Katkam
>            Assignee: Parth Chandra
>              Labels: doc-impacting
>             Fix For: 1.12.0
>
>
> Support SSL between Drillbit and JDBC/ODBC drivers. Drill already supports HTTPS for
web traffic.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message