drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-5337) OpenTSDB storage plugin
Date Mon, 30 Oct 2017 13:25:10 GMT

    [ https://issues.apache.org/jira/browse/DRILL-5337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16224940#comment-16224940
] 

ASF GitHub Bot commented on DRILL-5337:
---------------------------------------

Github user arina-ielchiieva commented on a diff in the pull request:

    https://github.com/apache/drill/pull/774#discussion_r146135774
  
    --- Diff: contrib/storage-opentsdb/src/main/java/org/apache/drill/exec/store/openTSDB/OpenTSDBScanSpec.java
---
    @@ -0,0 +1,35 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.drill.exec.store.openTSDB;
    +
    +import com.fasterxml.jackson.annotation.JsonCreator;
    +import com.fasterxml.jackson.annotation.JsonProperty;
    +
    +public class OpenTSDBScanSpec {
    +
    +  private final String tableName;
    +
    +  @JsonCreator
    +  public OpenTSDBScanSpec(@JsonProperty("tableName") String tableName) {
    +    this.tableName = tableName;
    +  }
    +
    +  public String getTableName() {
    +    return tableName;
    +  }
    --- End diff --
    
    If you'll do expain plan for the query:
    ```
    0: jdbc:drill:drillbit=localhost> explain plan for SELECT * FROM openTSDB.`(metric=mymetric.stock)`;
    +------+------+
    | text | json |
    +------+------+
    | 00-00    Screen
    00-01      Project(metric=[$0], aggregate tags=[$1], timestamp=[$2], aggregated value=[$3],
symbol=[$4])
    00-02        Scan(groupscan=[OpenTSDBGroupScan [OpenTSDBScanSpec=org.apache.drill.exec.store.openTSDB.OpenTSDBScanSpec@57979642]])
     | {
      "head" : {
        "version" : 1,
        "generator" : {
          "type" : "ExplainHandler",
          "info" : ""
        },
        "type" : "APACHE_DRILL_PHYSICAL",
        "options" : [ ],
        "queue" : 0,
        "hasResourcePlan" : false,
        "resultMode" : "EXEC"
      },
      "graph" : [ {
        "pop" : "openTSDB-scan",
        "@id" : 2,
        "openTSDBScanSpec" : {
          "tableName" : "(metric=mymetric.stock)"
        },
        "cost" : 0.0
      }, {
        "pop" : "project",
        "@id" : 1,
        "exprs" : [ {
          "ref" : "`metric`",
          "expr" : "`metric`"
        }, {
          "ref" : "`aggregate tags`",
          "expr" : "`aggregate tags`"
        }, {
          "ref" : "`timestamp`",
          "expr" : "`timestamp`"
        }, {
          "ref" : "`aggregated value`",
          "expr" : "`aggregated value`"
        }, {
          "ref" : "`symbol`",
          "expr" : "`symbol`"
        } ],
        "child" : 2,
        "outputProj" : true,
        "initialAllocation" : 1000000,
        "maxAllocation" : 10000000000,
        "cost" : 1.0
      }, {
        "pop" : "screen",
        "@id" : 0,
        "child" : 1,
        "initialAllocation" : 1000000,
        "maxAllocation" : 10000000000,
        "cost" : 1.0
      } ]
    } |
    +------+------+
    ```
    you'll see `OpenTSDBScanSpec=org.apache.drill.exec.store.openTSDB.OpenTSDBScanSpec@57979642`.
    I guess we might want to add `toString()` method in this class.


> OpenTSDB storage plugin
> -----------------------
>
>                 Key: DRILL-5337
>                 URL: https://issues.apache.org/jira/browse/DRILL-5337
>             Project: Apache Drill
>          Issue Type: New Feature
>          Components: Storage - Other
>            Reporter: Dmitriy Gavrilovych
>            Assignee: Dmitriy Gavrilovych
>              Labels: features
>             Fix For: 1.12.0
>
>
> Storage plugin for OpenTSDB
> The plugin uses REST API to work with TSDB. 
> Expected queries are listed below:
> SELECT * FROM openTSDB.`warp.speed.test`;
> Return all elements from warp.speed.test table with default aggregator SUM
> SELECT * FROM openTSDB.`(metric=warp.speed.test)`;
> Return all elements from (metric=warp.speed.test) table as a previous query, but with
alternative FROM syntax
> SELECT * FROM openTSDB.`(metric=warp.speed.test, aggregator=avg)`;
> Return all elements from warp.speed.test table, but with the custom aggregator
> SELECT `timestamp`, sum(`aggregated value`) FROM openTSDB.`(metric=warp.speed.test, aggregator=avg)`
GROUP BY `timestamp`;
> Return aggregated and grouped value by standard drill functions from warp.speed.test
table, but with the custom aggregator
> SELECT * FROM openTSDB.`(metric=warp.speed.test, downsample=5m-avg)`
> Return data limited by downsample



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message