Mailing-List: contact issues-help@drill.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@drill.apache.org
Date: Mon, 11 Sep 2017 17:12:00 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@drill.apache.org
Message-ID: <JIRA.13094889.1502837142000.80910.1505149920525@Atlassian.JIRA>
In-Reply-To: <JIRA.13094889.1502837142000@Atlassian.JIRA>
References: <JIRA.13094889.1502837142000@Atlassian.JIRA> <JIRA.13094889.1502837142575@jira-lw-us.apache.org>
Subject: [jira] [Commented] (DRILL-5723) Support System/Session Internal
 Options And Additional Option System Fixes
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Mon, 11 Sep 2017 17:12:08 -0000


    [ https://issues.apache.org/jira/browse/DRILL-5723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16161594#comment-16161594 ] 

ASF GitHub Bot commented on DRILL-5723:
---------------------------------------

Github user ilooner commented on a diff in the pull request:

    https://github.com/apache/drill/pull/923#discussion_r138132972
  
    --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/RestClientFixture.java ---
    @@ -0,0 +1,117 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.drill.test;
    +
    +import com.google.common.base.Preconditions;
    +import org.apache.drill.exec.ExecConstants;
    +import org.apache.drill.exec.server.rest.StatusResources;
    +import org.glassfish.jersey.client.ClientConfig;
    +import org.glassfish.jersey.client.JerseyClientBuilder;
    +
    +import javax.annotation.Nullable;
    +import javax.ws.rs.client.Client;
    +import javax.ws.rs.client.WebTarget;
    +import javax.ws.rs.core.GenericType;
    +import javax.ws.rs.core.MediaType;
    +
    +import java.util.List;
    +
    +/**
    + * Represents a client for the Drill Rest API.
    + */
    +public class RestClientFixture implements AutoCloseable {
    +  /**
    +   * A builder for the rest client.
    +   */
    +  public static class Builder {
    +    private ClusterFixture cluster;
    +
    +    public Builder(ClusterFixture cluster) {
    +      this.cluster = Preconditions.checkNotNull(cluster);
    +    }
    +
    +    public RestClientFixture build() {
    +      return new RestClientFixture(cluster);
    +    }
    +  }
    +
    +  private WebTarget baseTarget;
    +  private Client client;
    --- End diff --
    
    done


> Support System/Session Internal Options And Additional Option System Fixes
> --------------------------------------------------------------------------
>
>                 Key: DRILL-5723
>                 URL: https://issues.apache.org/jira/browse/DRILL-5723
>             Project: Apache Drill
>          Issue Type: New Feature
>            Reporter: Timothy Farkas
>            Assignee: Timothy Farkas
>
> This is a feature proposed by [~ben-zvi].
> Currently all the options are accessible by the user in sys.options. We would like to add internal options which can be altered, but are not visible in the sys.options table. These internal options could be seen by another alias select * from internal.options. The intention would be to put new options we weren't comfortable with exposing to the end user in this table.
> After the options and their corresponding features are considered stable they could be changed to appear in the sys.option table.
> A bunch of other fixes to the Option system have been clubbed into this:
> * OptionValidators no longer hold default values. Default values are contained in the SystemOptionManager
> * Options have an OptionDefinition. The option definition includes:
>   * A validator
>   * Metadata about the options visibility, required permissions, and the scope in which it can be set.
> * The Option Manager interface has been cleaned up so that a Type is not required to be passed in in order to set and delete options


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)