Mailing-List: contact issues-help@drill.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@drill.apache.org
Date: Mon, 4 Sep 2017 17:31:00 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@drill.apache.org
Message-ID: <JIRA.13093349.1502241081000.22873.1504546260350@Atlassian.JIRA>
In-Reply-To: <JIRA.13093349.1502241081000@Atlassian.JIRA>
References: <JIRA.13093349.1502241081000@Atlassian.JIRA> <JIRA.13093349.1502241081286@jira-lw-us.apache.org>
Subject: [jira] [Commented] (DRILL-5709) Provide a value vector method to
 convert a vector to nullable
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Mon, 04 Sep 2017 17:40:19 -0000


    [ https://issues.apache.org/jira/browse/DRILL-5709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16152814#comment-16152814 ] 

ASF GitHub Bot commented on DRILL-5709:
---------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/drill/pull/901


> Provide a value vector method to convert a vector to nullable
> -------------------------------------------------------------
>
>                 Key: DRILL-5709
>                 URL: https://issues.apache.org/jira/browse/DRILL-5709
>             Project: Apache Drill
>          Issue Type: Improvement
>            Reporter: Paul Rogers
>            Assignee: Paul Rogers
>            Priority: Minor
>              Labels: ready-to-commit
>             Fix For: 1.12.0
>
>
> The hash agg spill work has need to convert a non-null scalar vector to the nullable equivalent. For efficiency, the code wishes to simply transfer the underlying data buffer(s), and create the required "bits" vector, rather than generating code that does the transfer row-by-row.
> The solution is to add a {{toNullable(ValueVector nullableVector)}} method to the {{ValueVector}} class, then implement it where needed.
> Since the target code only works with scalars (that is, no arrays, no maps, no lists), the code only handles these cases, throwing an {{UnsupportedOperationException}} in other cases.
> Usage:
> {code}
> ValueVector nonNullableVector = // your non-nullable vector
> MajorType type = MajorType.newBuilder(nonNullableVector.getType)
>     .setMode(DataMode.OPTIONAL)
>     .build();
> MaterializedField field = MaterializedField.create(name, type);
> ValueVector nullableVector = TypeHelper.getNewVector(field, oContext.getAllocator());
> nonNullableVector.toNullable(nullableVector);
> // Data is now in nullableVector
> {code}


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)