drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-5830) Resolve regressions to MapR DB from DRILL-5546
Date Sat, 30 Sep 2017 23:20:02 GMT

    [ https://issues.apache.org/jira/browse/DRILL-5830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16187228#comment-16187228
] 

ASF GitHub Bot commented on DRILL-5830:
---------------------------------------

Github user vdiravka commented on a diff in the pull request:

    https://github.com/apache/drill/pull/968#discussion_r142017186
  
    --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/QueryRowSetIterator.java
---
    @@ -0,0 +1,113 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.drill.test;
    +
    +import java.util.Iterator;
    +
    +import org.apache.drill.exec.exception.SchemaChangeException;
    +import org.apache.drill.exec.memory.BufferAllocator;
    +import org.apache.drill.exec.proto.UserBitShared.QueryId;
    +import org.apache.drill.exec.proto.UserBitShared.QueryResult.QueryState;
    +import org.apache.drill.exec.proto.helper.QueryIdHelper;
    +import org.apache.drill.exec.record.RecordBatchLoader;
    +import org.apache.drill.exec.record.VectorContainer;
    +import org.apache.drill.exec.rpc.user.QueryDataBatch;
    +import org.apache.drill.test.BufferingQueryEventListener.QueryEvent;
    +import org.apache.drill.test.rowSet.DirectRowSet;
    +
    +public class QueryRowSetIterator implements Iterator<DirectRowSet>, Iterable<DirectRowSet>
{
    --- End diff --
    
    I have a compilation error here. Please implement remove() method from Iterator interface.


> Resolve regressions to MapR DB from DRILL-5546
> ----------------------------------------------
>
>                 Key: DRILL-5830
>                 URL: https://issues.apache.org/jira/browse/DRILL-5830
>             Project: Apache Drill
>          Issue Type: Bug
>    Affects Versions: 1.12.0
>            Reporter: Paul Rogers
>            Assignee: Paul Rogers
>             Fix For: 1.12.0
>
>
> DRILL-5546 added a number of fixes for empty batches. One part of the fix was for HBase.
Key changes:
> * Add code to expand wildcards in the planner. (i.e. SELECT *)
> * Remove support for wildcards in the HBase record reader.
> As noted in DRILL-5775, this change had the effect of breaking support for MapR-DB binary
(which is API compatible with HBase.) DRILL-5775 does this by expanding wildcards in the planner
for MapR DB as was done for HBase in DRILL-5546.
> Unfortunately, this change introduced other regressions into the code as described by
DRILL-5706.
> Investigation of those issues revealed that we should back out the original DRILL-5546
changes and go down a different route.
> As it turns out, HBase already had a project push-down rule that expanded wildcards.
However, that rule didn't work correctly some of the time. DRILL-5546 fixed that bug, ensuring
that wildcards are expanded (at least in the cases tested for this ticket.)
> The actual issue turned out to be a bug in the {{RecordBatchLoader}} class which did
not consider map contents when detecting schema change. As a result, results like (row_key,
cf\{}) were treated the same as (row_key, cf\{mycol}) and the actual data colums were discarded,
but randomly depending on batch arrival order.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message