drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Julian Hyde (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-5800) Explicitly set locale to en_US on locale-dependent tests
Date Mon, 18 Sep 2017 08:45:02 GMT

    [ https://issues.apache.org/jira/browse/DRILL-5800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16169759#comment-16169759
] 

Julian Hyde commented on DRILL-5800:
------------------------------------

The position we took in calcite was that code shouldn't depend on the jvm's locale. As a server
we want to operate in the client's locale.

If drill has the same policy, your change is masking a bug. And besides, your change will
affect subsequent tests run in the same vm. It might potentially cause indeterminacy in the
test suite. 

> Explicitly set locale to en_US on locale-dependent tests
> --------------------------------------------------------
>
>                 Key: DRILL-5800
>                 URL: https://issues.apache.org/jira/browse/DRILL-5800
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Tools, Build & Test
>            Reporter: Uwe L. Korn
>
> Some tests depend on the locale, i.e. they run with {{en_US}} successfully but fail with
{{de_DE}} due to a different decimal separator.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message