drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-5745) Invalid "location" information in Drill web server
Date Tue, 19 Sep 2017 07:09:00 GMT

    [ https://issues.apache.org/jira/browse/DRILL-5745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16171210#comment-16171210
] 

ASF GitHub Bot commented on DRILL-5745:
---------------------------------------

GitHub user prasadns14 opened a pull request:

    https://github.com/apache/drill/pull/948

    DRILL-5745: Corrected 'location' information in Drill web server

    Updated the 'location' information in Drill web server to-
    1) consider if HTTPS is enabled
    2) use the foreman address rather than "localhost"
    3) use the set HTTP port
    
    @paul-rogers, please review

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/prasadns14/drill DRILL-5745

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/948.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #948
    
----
commit a8858d278eaf5ba648ce783cc7f1c6d6ba53689a
Author: Prasad Subramanya <prasadsubramanya@psubram-1010.local>
Date:   2017-09-19T06:59:01Z

    DRILL-5745: Corrected 'location' information in Drill web server

----


> Invalid "location" information in Drill web server
> --------------------------------------------------
>
>                 Key: DRILL-5745
>                 URL: https://issues.apache.org/jira/browse/DRILL-5745
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Web Server
>    Affects Versions: 1.11.0
>            Reporter: Paul Rogers
>            Priority: Minor
>
> The file {{ProfileResources.java}} has the following incorrect code line:
> {code}
>       this.location = "http://localhost:8047/profile/" + queryId + ".json";
> {code}
> This code makes three errors.
> 1. The "http" prefix ignores the fact that the Drillbit can have SSL enabled for the
web server.
> 2. In a browser, "localhost" refers to the the machine running the browser. This is valid
only if the browser runs on the same machine as the Drillbit, which is not, in general, true.
> 3. The port number is hardcoded to 8047, but it can be customized in the config file.
> Therefore, most of the time, the link won't work on a production server.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message