drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-5709) Provide a value vector method to convert a vector to nullable
Date Mon, 04 Sep 2017 17:31:00 GMT

    [ https://issues.apache.org/jira/browse/DRILL-5709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16152814#comment-16152814

ASF GitHub Bot commented on DRILL-5709:

Github user asfgit closed the pull request at:


> Provide a value vector method to convert a vector to nullable
> -------------------------------------------------------------
>                 Key: DRILL-5709
>                 URL: https://issues.apache.org/jira/browse/DRILL-5709
>             Project: Apache Drill
>          Issue Type: Improvement
>            Reporter: Paul Rogers
>            Assignee: Paul Rogers
>            Priority: Minor
>              Labels: ready-to-commit
>             Fix For: 1.12.0
> The hash agg spill work has need to convert a non-null scalar vector to the nullable
equivalent. For efficiency, the code wishes to simply transfer the underlying data buffer(s),
and create the required "bits" vector, rather than generating code that does the transfer
> The solution is to add a {{toNullable(ValueVector nullableVector)}} method to the {{ValueVector}}
class, then implement it where needed.
> Since the target code only works with scalars (that is, no arrays, no maps, no lists),
the code only handles these cases, throwing an {{UnsupportedOperationException}} in other
> Usage:
> {code}
> ValueVector nonNullableVector = // your non-nullable vector
> MajorType type = MajorType.newBuilder(nonNullableVector.getType)
>     .setMode(DataMode.OPTIONAL)
>     .build();
> MaterializedField field = MaterializedField.create(name, type);
> ValueVector nullableVector = TypeHelper.getNewVector(field, oContext.getAllocator());
> nonNullableVector.toNullable(nullableVector);
> // Data is now in nullableVector
> {code}

This message was sent by Atlassian JIRA

View raw message