drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sorabh Hamirwasia (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-5558) Unexpected state by SendResult is ignored
Date Thu, 21 Sep 2017 06:09:00 GMT

    [ https://issues.apache.org/jira/browse/DRILL-5558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16174319#comment-16174319
] 

Sorabh Hamirwasia commented on DRILL-5558:
------------------------------------------

I think we have to first define the behavior here. Based on my understanding if the state
received by client from server is unknown then user should receive failure response back via
submissionFailed with proper error message or exception.

> Unexpected state by SendResult is ignored
> -----------------------------------------
>
>                 Key: DRILL-5558
>                 URL: https://issues.apache.org/jira/browse/DRILL-5558
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Client - Java, Web Server
>    Affects Versions: 1.10.0
>            Reporter: Sorabh Hamirwasia
>
> Final state of a query is sent from Foreman to client using _sendResult_. If the state
being reported is unexpected one then it's [ignored|https://github.com/apache/drill/blob/master/exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/QueryResultHandler.java#L134].
This should be handled on client side and reported to client accordingly rather than just
ignoring it. Since it's a terminal message for a query, ignoring the unexpected state from
server can lead to query stay in an illegal state.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message