drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-5431) Support SSL
Date Fri, 22 Sep 2017 03:47:07 GMT

    [ https://issues.apache.org/jira/browse/DRILL-5431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16175883#comment-16175883
] 

ASF GitHub Bot commented on DRILL-5431:
---------------------------------------

Github user sohami commented on a diff in the pull request:

    https://github.com/apache/drill/pull/950#discussion_r140400536
  
    --- Diff: exec/rpc/src/main/java/org/apache/drill/exec/rpc/BasicServer.java ---
    @@ -82,6 +83,9 @@ protected void initChannel(SocketChannel ch) throws Exception {
                 ch.closeFuture().addListener(getCloseHandler(ch, connection));
     
                 final ChannelPipeline pipe = ch.pipeline();
    +            // Make sure that the SSL handler is the first handler in the pipeline so
everything is encrypted
    +            setupSSL(pipe);
    --- End diff --
    
    how about checking `isSslEnabled()` and then calling `setupSSL(..)` here and in `BasicClient`
? instead of checking it inside the `setupSSL` function. Since cases when SSL is disabled
that will avoid the function call.


> Support SSL
> -----------
>
>                 Key: DRILL-5431
>                 URL: https://issues.apache.org/jira/browse/DRILL-5431
>             Project: Apache Drill
>          Issue Type: New Feature
>          Components: Client - Java, Client - ODBC
>            Reporter: Sudheesh Katkam
>            Assignee: Sudheesh Katkam
>
> Support SSL between Drillbit and JDBC/ODBC drivers. Drill already supports HTTPS for
web traffic.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message