drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-5431) Support SSL
Date Fri, 22 Sep 2017 03:47:04 GMT

    [ https://issues.apache.org/jira/browse/DRILL-5431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16175855#comment-16175855
] 

ASF GitHub Bot commented on DRILL-5431:
---------------------------------------

Github user sohami commented on a diff in the pull request:

    https://github.com/apache/drill/pull/950#discussion_r140133705
  
    --- Diff: exec/rpc/src/main/java/org/apache/drill/exec/rpc/BasicClient.java ---
    @@ -100,6 +103,8 @@ protected void initChannel(SocketChannel ch) throws Exception {
                 ch.closeFuture().addListener(getCloseHandler(ch, connection));
     
                 final ChannelPipeline pipe = ch.pipeline();
    +            // Make sure that the SSL handler is the first handler in the pipeline so
everything is encrypted
    +            setupSSL(pipe, sslHandshakeListener);
    --- End diff --
    
    this will be called all the time even when SSL is not enabled and then later we have a
check inside setupSSL where we are doing all the setup inside that if condition. How about
check that here instead and then calling setupSSL method based on that check ? That way we
know setupSSL is to do some setup and will be called only when SSL is enabled.
    ```
    
    if (isSslEnabled()) {
       sslHandshakeListener = new ConnectionMultiListener.SSLHandshakeListener();
        setupSSL(pipe, sslHandshakeListener);
    }
    ```
    and then remove that check from inside the setupSSL method.


> Support SSL
> -----------
>
>                 Key: DRILL-5431
>                 URL: https://issues.apache.org/jira/browse/DRILL-5431
>             Project: Apache Drill
>          Issue Type: New Feature
>          Components: Client - Java, Client - ODBC
>            Reporter: Sudheesh Katkam
>            Assignee: Sudheesh Katkam
>
> Support SSL between Drillbit and JDBC/ODBC drivers. Drill already supports HTTPS for
web traffic.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message