drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-5431) Support SSL
Date Fri, 22 Sep 2017 03:47:04 GMT

    [ https://issues.apache.org/jira/browse/DRILL-5431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16175854#comment-16175854
] 

ASF GitHub Bot commented on DRILL-5431:
---------------------------------------

Github user sohami commented on a diff in the pull request:

    https://github.com/apache/drill/pull/950#discussion_r140124213
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java ---
    @@ -126,10 +138,10 @@
       String HTTP_SESSION_MEMORY_RESERVATION = "drill.exec.http.session.memory.reservation";
       String HTTP_SESSION_MEMORY_MAXIMUM = "drill.exec.http.session.memory.maximum";
       String HTTP_SESSION_MAX_IDLE_SECS = "drill.exec.http.session_max_idle_secs";
    -  String HTTP_KEYSTORE_PATH = "drill.exec.ssl.keyStorePath";
    -  String HTTP_KEYSTORE_PASSWORD = "drill.exec.ssl.keyStorePassword";
    -  String HTTP_TRUSTSTORE_PATH = "drill.exec.ssl.trustStorePath";
    -  String HTTP_TRUSTSTORE_PASSWORD = "drill.exec.ssl.trustStorePassword";
    +  String HTTP_KEYSTORE_PATH = SSL_KEYSTORE_PATH;
    +  String HTTP_KEYSTORE_PASSWORD = SSL_KEYSTORE_PASSWORD;
    +  String HTTP_TRUSTSTORE_PATH = SSL_TRUSTSTORE_PATH;
    +  String HTTP_TRUSTSTORE_PASSWORD = SSL_TRUSTSTORE_PASSWORD;
    --- End diff --
    
    Why not just keep _SSL_KEYSTORE_ and _SSL_TRUSTSTORE_ constants and remove the HTTP ones
?


> Support SSL
> -----------
>
>                 Key: DRILL-5431
>                 URL: https://issues.apache.org/jira/browse/DRILL-5431
>             Project: Apache Drill
>          Issue Type: New Feature
>          Components: Client - Java, Client - ODBC
>            Reporter: Sudheesh Katkam
>            Assignee: Sudheesh Katkam
>
> Support SSL between Drillbit and JDBC/ODBC drivers. Drill already supports HTTPS for
web traffic.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message