Mailing-List: contact issues-help@drill.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@drill.apache.org
Date: Fri, 25 Aug 2017 11:43:00 +0000 (UTC)
From: "Arina Ielchiieva (JIRA)" <jira@apache.org>
To: issues@drill.apache.org
Message-ID: <JIRA.13092008.1501709038000.120249.1503661380308@Atlassian.JIRA>
In-Reply-To: <JIRA.13092008.1501709038000@Atlassian.JIRA>
References: <JIRA.13092008.1501709038000@Atlassian.JIRA> <JIRA.13092008.1501709038038@jira-lw-us.apache.org>
Subject: [jira] [Updated] (DRILL-5701)
 drill.connections.rpc.<user/control/data>.<encrypted/unencrypted> metric
 not behaving correctly
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
archived-at: Fri, 25 Aug 2017 11:43:04 -0000


     [ https://issues.apache.org/jira/browse/DRILL-5701?page=3Dcom.atlassia=
n.jira.plugin.system.issuetabpanels:all-tabpanel ]

Arina Ielchiieva updated DRILL-5701:
------------------------------------
    Reviewer: Karthikeyan Manivannan

> drill.connections.rpc.<user/control/data>.<encrypted/unencrypted> metric =
not behaving correctly
> -------------------------------------------------------------------------=
----------------------
>
>                 Key: DRILL-5701
>                 URL: https://issues.apache.org/jira/browse/DRILL-5701
>             Project: Apache Drill
>          Issue Type: Bug
>    Affects Versions: 1.11.0
>            Reporter: Sorabh Hamirwasia
>            Assignee: Sorabh Hamirwasia
>              Labels: ready-to-commit
>             Fix For: 1.12.0
>
>
> Reported by [~knguyen]
> When sqlline fails to connect to drillbit such as a handshake failure, th=
e drill.connections.rpc.user.<encrypted/unencrypted> metric subtracts 2 cou=
nters (one for handshake failure and one when the user exits from sqlline).=
 As a result, the metric can end up with a negative value. For control conn=
ections if the handshake fails then again counters related to those are upd=
ated incorrectly.
> *Issue Details:*
> With the current implementation to update counter, the connection counter=
 will be incremented only when a handshake (Drill + SASL handshake) was suc=
cessful, not with creation of a valid TCP connection. But the counter was d=
ecremented in the channel closed callback of Netty which will be called whe=
n TCP connection is teared down. Hence in case when Drill handshake fails e=
ven though it has a valid TCP connection there won't be any increment. But =
as part of handshake failure the TCP connection will be closed by Netty and=
 that results in decrement of the counter, which results in negative value =
of the counter. When using Sqlline as client, if there is failure based on =
above use case then the counter is decremented by 1 value. But later when *=
quit* command is issued in sqlline then internally it again's tries to make=
 another connection which will follow the same flow above and will again de=
crement the counter making the negative value of 2. From Drill's perspectiv=
e the issue is we don't increment the connection count with a valid TCP con=
nection but decrements it only in close of TCP connection. So with this PR =
we are addressing those issues. Similar was a case for other channel counte=
rs as well.=20


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)