Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 2A12C200CD7 for ; Tue, 1 Aug 2017 20:39:04 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 28B321679B9; Tue, 1 Aug 2017 18:39:04 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 6528F167991 for ; Tue, 1 Aug 2017 20:39:03 +0200 (CEST) Received: (qmail 34635 invoked by uid 500); 1 Aug 2017 18:39:02 -0000 Mailing-List: contact issues-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list issues@drill.apache.org Received: (qmail 34626 invoked by uid 99); 1 Aug 2017 18:39:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 Aug 2017 18:39:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 0BBD218070D for ; Tue, 1 Aug 2017 18:39:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id 97OguuHTXl4m for ; Tue, 1 Aug 2017 18:39:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 2E68A5F3CC for ; Tue, 1 Aug 2017 18:39:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 7D4BEE09A4 for ; Tue, 1 Aug 2017 18:39:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 3A4C82464E for ; Tue, 1 Aug 2017 18:39:00 +0000 (UTC) Date: Tue, 1 Aug 2017 18:39:00 +0000 (UTC) From: "Chunhui Shi (JIRA)" To: issues@drill.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (DRILL-5696) change default compiler strategy MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 01 Aug 2017 18:39:04 -0000 [ https://issues.apache.org/jira/browse/DRILL-5696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16109482#comment-16109482 ] Chunhui Shi commented on DRILL-5696: ------------------------------------ Kunal, can you help looking at the compilation time of large queries with JDK7/8 and Janin's performance issue? Also we need to measure the efficiency of generated code before making decision. > change default compiler strategy > -------------------------------- > > Key: DRILL-5696 > URL: https://issues.apache.org/jira/browse/DRILL-5696 > Project: Apache Drill > Issue Type: Improvement > Components: Execution - Codegen > Affects Versions: 1.9.0, 1.10.0, 1.11.0 > Reporter: weijie.tong > Assignee: Kunal Khatua > > at our production ,when we have more than 20 agg expression, the compile time is high using the default janino. but when changed to jdk compiler,we gain fewer compile time than the janino one. Our product jdk version is 1.8. > So the default one should be JDK , if user's jdk version is upper than 1.7. We should add another check condition to the ClassCompilerSelector. -- This message was sent by Atlassian JIRA (v6.4.14#64029)