drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-5717) change some date time unit cases with specific timezone or Local
Date Tue, 29 Aug 2017 17:16:00 GMT

    [ https://issues.apache.org/jira/browse/DRILL-5717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16145713#comment-16145713
] 

ASF GitHub Bot commented on DRILL-5717:
---------------------------------------

Github user vvysotskyi commented on a diff in the pull request:

    https://github.com/apache/drill/pull/904#discussion_r135851159
  
    --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestDateFunctions.java
---
    @@ -135,11 +139,16 @@ public void testIntervalArithmetic() throws Exception {
     
         @Test
         public void testToChar() throws Exception {
    -
    -        String expectedResults[] = {(new LocalDate(2008, 2, 23)).toString("yyyy-MMM-dd"),
    +        Locale defaultLocale = Locale.getDefault();
    +        try{
    +          Locale.setDefault(new Locale("en", "US"));
    --- End diff --
    
    Please replace `new Locale("en", "US")` by `Locale.US`


> change some date time unit cases with specific timezone or Local
> ----------------------------------------------------------------
>
>                 Key: DRILL-5717
>                 URL: https://issues.apache.org/jira/browse/DRILL-5717
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Tools, Build & Test
>    Affects Versions: 1.9.0, 1.11.0
>            Reporter: weijie.tong
>
> Some date time test cases like  JodaDateValidatorTest  is not Local independent .This
will cause other Local's users's test phase to fail. We should let these test cases to be
Local env independent.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message