drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-5665) planner.force_2phase.aggr Set to TRUE for HashAgg may cause wrong results for VARIANCE and STD_DEV
Date Tue, 11 Jul 2017 02:56:00 GMT

    [ https://issues.apache.org/jira/browse/DRILL-5665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16081561#comment-16081561
] 

ASF GitHub Bot commented on DRILL-5665:
---------------------------------------

GitHub user Ben-Zvi opened a pull request:

    https://github.com/apache/drill/pull/872

    DRILL-5665: planner.force_2phase_aggr only overrides small inputs

    The planner option planner.force_2phase_aggr was created for testing, but may be used
someday by a customer to allow spilling (currently single phase can not spill).
    That option was implemented unconditionally, thus potentially violating other checks.
    
    The code change is to only use this option to bypass a single check -- for small input
tables.
      

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Ben-Zvi/drill DRILL-5665

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/872.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #872
    
----
commit 2e185c018fa10843dbe4a486b483d33b4d469ceb
Author: Boaz Ben-Zvi <boazben-zvi@bbenzvi-e754-mbp13.local>
Date:   2017-07-11T01:52:52Z

    DRILL-5665: planner.force_2phase_aggr only overrides small inputs

----


> planner.force_2phase.aggr Set to TRUE for HashAgg may cause wrong results for VARIANCE
and STD_DEV
> --------------------------------------------------------------------------------------------------
>
>                 Key: DRILL-5665
>                 URL: https://issues.apache.org/jira/browse/DRILL-5665
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Execution - Relational Operators
>    Affects Versions: 1.11.0
>            Reporter: Boaz Ben-Zvi
>            Assignee: Boaz Ben-Zvi
>             Fix For: 1.11.0
>
>
> *planner.force_2phase.aggr* was added for testing the hash 2-phase spill to disk aggregation
implementation. However, if it is set to true, stream aggregate will run in two phase too
and return wrong results for some functions such as variance() and std_dev().



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message