drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-5663) Drillbit fails to start when only keystore path is provided without keystore password.
Date Fri, 28 Jul 2017 21:00:06 GMT

    [ https://issues.apache.org/jira/browse/DRILL-5663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16105654#comment-16105654
] 

ASF GitHub Bot commented on DRILL-5663:
---------------------------------------

Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/874#discussion_r130182034
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/WebServer.java
---
    @@ -263,18 +272,17 @@ private ServerConnector createHttpsConnector() throws Exception
{
         logger.info("Setting up HTTPS connector for web server");
     
         final SslContextFactory sslContextFactory = new SslContextFactory();
    +    SSLConfig ssl = new SSLConfig(config);
     
    -    if (config.hasPath(ExecConstants.HTTP_KEYSTORE_PATH) &&
    -        !Strings.isNullOrEmpty(config.getString(ExecConstants.HTTP_KEYSTORE_PATH))) {
    +    if(ssl.isValid){
    --- End diff --
    
    `if (ssl.isValid) {`
    
    Here, `isValid` means `isSslEnabled`.
    
    Better: `ssl.isEnabled()`


> Drillbit fails to start when only keystore path is provided without keystore password.
> --------------------------------------------------------------------------------------
>
>                 Key: DRILL-5663
>                 URL: https://issues.apache.org/jira/browse/DRILL-5663
>             Project: Apache Drill
>          Issue Type: Bug
>            Reporter: Sorabh Hamirwasia
>            Assignee: Sindhuri Ramanarayan Rayavaram
>
> When we configure keystore path without keystore password inside drill-override.conf
for WebServer, then Drillbit fails to start. We should explicitly check for either both being
present or both being absent. If any one of them is only present then throw startup exception
for Drill.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message