drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-5601) Rollup of External Sort memory management fixes
Date Wed, 19 Jul 2017 18:00:04 GMT

    [ https://issues.apache.org/jira/browse/DRILL-5601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16093521#comment-16093521
] 

ASF GitHub Bot commented on DRILL-5601:
---------------------------------------

Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/860#discussion_r128144906
  
    --- Diff: exec/vector/src/main/java/org/apache/drill/exec/vector/AllocationHelper.java
---
    @@ -26,14 +26,16 @@ public static void allocate(ValueVector v, int valueCount, int bytesPerValue)
{
         allocate(v, valueCount, bytesPerValue, 5);
       }
     
    -  public static void allocatePrecomputedChildCount(ValueVector v, int valueCount, int
bytesPerValue, int childValCount){
    -    if(v instanceof FixedWidthVector) {
    +  public static void allocatePrecomputedChildCount(ValueVector v, int valueCount, int
bytesPerValue, int childValCount) {
    --- End diff --
    
    Well, sure. But, notice that I didn't write this; I only added a space. But, I went ahead
and renamed all the "v"s...


> Rollup of External Sort memory management fixes
> -----------------------------------------------
>
>                 Key: DRILL-5601
>                 URL: https://issues.apache.org/jira/browse/DRILL-5601
>             Project: Apache Drill
>          Issue Type: Task
>    Affects Versions: 1.11.0
>            Reporter: Paul Rogers
>            Assignee: Paul Rogers
>             Fix For: 1.12.0
>
>
> Rollup of a set of specific JIRA entries that all relate to the very difficult problem
of managing memory within Drill in order for the external sort to stay within a memory budget.
In general, the fixes relate to better estimating memory used by the three ways that Drill
allocates vector memory (see DRILL-5522) and to predicting the size of vectors that the sort
will create, to avoid repeated realloc-copy cycles (see DRILL-5594).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message