drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-5601) Rollup of External Sort memory management fixes
Date Thu, 13 Jul 2017 22:21:00 GMT

    [ https://issues.apache.org/jira/browse/DRILL-5601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16086499#comment-16086499
] 

ASF GitHub Bot commented on DRILL-5601:
---------------------------------------

Github user Ben-Zvi commented on a diff in the pull request:

    https://github.com/apache/drill/pull/860#discussion_r127077314
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/PriorityQueueCopierWrapper.java
---
    @@ -100,10 +102,12 @@ private PriorityQueueCopier newCopier(VectorAccessible batch) {
        * @param batchGroupList
        * @param outputContainer
        * @param targetRecordCount
    +   * @param allocHelper
        * @return
        */
    -  public BatchMerger startMerge(BatchSchema schema, List<? extends BatchGroup>
batchGroupList, VectorContainer outputContainer, int targetRecordCount) {
    -    return new BatchMerger(this, schema, batchGroupList, outputContainer, targetRecordCount);
    +  public BatchMerger startMerge(BatchSchema schema, List<? extends BatchGroup>
batchGroupList,
    --- End diff --
    
    How about creating another **startMerge(...)** without the last **allocHelper** parameter,
which would then call **BatchMerger(......., null)** ; this new overloaded one would be used
in places like TestCopier.java, instead of adding a last null parameter there.


> Rollup of External Sort memory management fixes
> -----------------------------------------------
>
>                 Key: DRILL-5601
>                 URL: https://issues.apache.org/jira/browse/DRILL-5601
>             Project: Apache Drill
>          Issue Type: Task
>    Affects Versions: 1.11.0
>            Reporter: Paul Rogers
>            Assignee: Paul Rogers
>             Fix For: 1.12.0
>
>
> Rollup of a set of specific JIRA entries that all relate to the very difficult problem
of managing memory within Drill in order for the external sort to stay within a memory budget.
In general, the fixes relate to better estimating memory used by the three ways that Drill
allocates vector memory (see DRILL-5522) and to predicting the size of vectors that the sort
will create, to avoid repeated realloc-copy cycles (see DRILL-5594).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message