drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Arina Ielchiieva (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-5405) Add missing operator types without dependency on protobuf enum
Date Tue, 18 Jul 2017 10:27:00 GMT

    [ https://issues.apache.org/jira/browse/DRILL-5405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16091384#comment-16091384
] 

Arina Ielchiieva commented on DRILL-5405:
-----------------------------------------

No, issue is still valid. I have closed the PR since we'll need a new one. I have updated
Jira description reflect changes to be done:

{quote}
Though plugins work fine without this changes, it's still would be nice to display operator
type on Web UI.
But dependency on protobuf enum removes the ability for format plugins to truly be drop-in
pluggable.
In this case as option we may need to refactor this interface to just return a String and
not use the protobuf enum, or have a separate "notes" field if we want to have a generic filescan
operator ID in this enum with extra data to say what kind of scan we used.
{quote}

To replace protobuf usage with String we'll need to make changes in public interface. Maybe
it's a good item for Drill 2.0 release.


> Add missing operator types without dependency on protobuf enum
> --------------------------------------------------------------
>
>                 Key: DRILL-5405
>                 URL: https://issues.apache.org/jira/browse/DRILL-5405
>             Project: Apache Drill
>          Issue Type: Bug
>    Affects Versions: 1.10.0
>            Reporter: Arina Ielchiieva
>            Assignee: Arina Ielchiieva
>            Priority: Minor
>         Attachments: maprdb_sub_scan.JPG, unknown_operator.JPG
>
>
> Source - https://github.com/apache/drill/pull/214#discussion_r42687575
> Some operator types are not added in CoreOperatorType enum.
> For example, FLATTEN, MONGO_SUB_SCAN, MAPRDB_SUB_SCAN. Currently they are displayed on
Web UI as UNKNOWN_OPERATOR.
> Screenshots:
> now -> unknown_operator.JPG
> should be -> maprdb_sub_scan.JPG
> Though plugins work fine without this changes, it's still would be nice to display operator
type on Web UI.
> But dependency on protobuf enum removes the ability for format plugins to truly be drop-in
pluggable.
> In this case as option we may need to refactor this interface to just return a String
and not use the protobuf enum, or have a separate "notes" field if we want to have a generic
filescan operator ID in this enum with extra data to say what kind of scan we used.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message