drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pritesh Maker (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-5405) Add missing operator types without dependency on protobuf enum
Date Mon, 17 Jul 2017 22:17:00 GMT

    [ https://issues.apache.org/jira/browse/DRILL-5405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16090669#comment-16090669
] 

Pritesh Maker commented on DRILL-5405:
--------------------------------------

[~arina] should this be resolved now?

> Add missing operator types without dependency on protobuf enum
> --------------------------------------------------------------
>
>                 Key: DRILL-5405
>                 URL: https://issues.apache.org/jira/browse/DRILL-5405
>             Project: Apache Drill
>          Issue Type: Bug
>    Affects Versions: 1.10.0
>            Reporter: Arina Ielchiieva
>            Assignee: Arina Ielchiieva
>            Priority: Minor
>         Attachments: maprdb_sub_scan.JPG, unknown_operator.JPG
>
>
> Source - https://github.com/apache/drill/pull/214#discussion_r42687575
> Some operator types are not added in CoreOperatorType enum.
> For example, FLATTEN, MONGO_SUB_SCAN, MAPRDB_SUB_SCAN. Currently they are displayed on
Web UI as UNKNOWN_OPERATOR.
> Screenshots:
> now -> unknown_operator.JPG
> should be -> maprdb_sub_scan.JPG
> Though plugins work fine without this changes, it's still would be nice to display operator
type on Web UI.
> But dependency on protobuf enum removes the ability for format plugins to truly be drop-in
pluggable.
> In this case as option we may need to refactor this interface to just return a String
and not use the protobuf enum, or have a separate "notes" field if we want to have a generic
filescan operator ID in this enum with extra data to say what kind of scan we used.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message