Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 6F637200CBB for ; Mon, 19 Jun 2017 11:41:10 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 6C8A3160BE1; Mon, 19 Jun 2017 09:41:10 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id BA79E160BE4 for ; Mon, 19 Jun 2017 11:41:09 +0200 (CEST) Received: (qmail 92357 invoked by uid 500); 19 Jun 2017 09:41:09 -0000 Mailing-List: contact issues-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list issues@drill.apache.org Received: (qmail 92333 invoked by uid 99); 19 Jun 2017 09:41:07 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 19 Jun 2017 09:41:07 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 2900F1A0371 for ; Mon, 19 Jun 2017 09:41:07 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id ExldJNN_EtnC for ; Mon, 19 Jun 2017 09:41:06 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 977645FCB5 for ; Mon, 19 Jun 2017 09:41:05 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id B33E0E073C for ; Mon, 19 Jun 2017 09:41:03 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 1B79423FFD for ; Mon, 19 Jun 2017 09:41:00 +0000 (UTC) Date: Mon, 19 Jun 2017 09:41:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@drill.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (DRILL-5325) Implement sub-operator unit tests for managed external sort MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 19 Jun 2017 09:41:10 -0000 [ https://issues.apache.org/jira/browse/DRILL-5325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16053710#comment-16053710 ] ASF GitHub Bot commented on DRILL-5325: --------------------------------------- Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/808 +1 > Implement sub-operator unit tests for managed external sort > ----------------------------------------------------------- > > Key: DRILL-5325 > URL: https://issues.apache.org/jira/browse/DRILL-5325 > Project: Apache Drill > Issue Type: Improvement > Components: Tools, Build & Test > Affects Versions: 1.11.0 > Reporter: Paul Rogers > Assignee: Paul Rogers > Labels: ready-to-commit > Fix For: 1.11.0 > > > Validate the proposed sub-operator test framework, by creating low-level unit tests for the managed version of the external sort. > The external sort has a small number of existing tests, but those tests are quite superficial; the "managed sort" project found many bugs. The managed sort itself was tested with ad-hoc system-level tests created using the new "cluster fixture" framework. But, again, such tests could not reach deep inside the sort code to exercise very specific conditions. > As a result, we spent far too much time using QA functional tests to identify specific code issues. > Using the sub-opeator unit test framework, we can instead test each bit of functionality at the unit test level. > If doing so works, and is practical, it can serve as a model for other operator testing projects. -- This message was sent by Atlassian JIRA (v6.4.14#64029)