drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-5589) JDBC client crashes after successful authentication if trace logging is enabled.
Date Thu, 15 Jun 2017 20:13:00 GMT

    [ https://issues.apache.org/jira/browse/DRILL-5589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16051001#comment-16051001
] 

ASF GitHub Bot commented on DRILL-5589:
---------------------------------------

GitHub user sohami opened a pull request:

    https://github.com/apache/drill/pull/854

    DRILL-5589: JDBC client crashes after successful authentication if tr…

    …ace logging is enabled

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sohami/drill DRILL-5589

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/854.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #854
    
----
commit 0e6de7b798a2a1bf36b5ac0790ce47a41c905470
Author: Sorabh Hamirwasia <shamirwasia@maprtech.com>
Date:   2017-06-15T18:00:21Z

    DRILL-5589: JDBC client crashes after successful authentication if trace logging is enabled

----


> JDBC client crashes after successful authentication if trace logging is enabled.
> --------------------------------------------------------------------------------
>
>                 Key: DRILL-5589
>                 URL: https://issues.apache.org/jira/browse/DRILL-5589
>             Project: Apache Drill
>          Issue Type: Bug
>    Affects Versions: 1.11.0
>            Reporter: Sorabh Hamirwasia
>            Assignee: Sorabh Hamirwasia
>
> When authentication is completed then with latest changes we [dispose the saslClient
instance | https://github.com/apache/drill/blob/master/exec/java-exec/src/main/java/org/apache/drill/exec/rpc/security/AuthenticationOutcomeListener.java#L295]
if encryption is not enabled. Then later in caller we try to [log the mechanism name | https://github.com/apache/drill/blob/master/exec/java-exec/src/main/java/org/apache/drill/exec/rpc/security/AuthenticationOutcomeListener.java#L136]
using saslClient instance with trace level logging. This will cause the client to crash since
the saslClient instance is already disposed before logging. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message