drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-3640) Drill JDBC driver support Statement.setQueryTimeout(int)
Date Sat, 24 Jun 2017 00:34:03 GMT

    [ https://issues.apache.org/jira/browse/DRILL-3640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16061691#comment-16061691
] 

ASF GitHub Bot commented on DRILL-3640:
---------------------------------------

Github user kkhatua commented on a diff in the pull request:

    https://github.com/apache/drill/pull/858#discussion_r123865494
  
    --- Diff: exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillStatementImpl.java ---
    @@ -38,8 +44,12 @@
     // methods for compatibility.)
     class DrillStatementImpl extends AvaticaStatement implements DrillStatement,
                                                                  DrillRemoteStatement {
    +  //Not using the DrillbitContext's ExecutorService as this is threadPool is light-weight
(threads wake up to cancel tasks) but needs a low response time
    +  private static ExecutorService queryTimeoutTaskPool = Executors.newCachedThreadPool(new
NamedThreadFactory("q-timeout-"));
    --- End diff --
    
    Using a threadPool model is actually making the solution simpler, since I'm triggering
the query cancellation. The TimeoutTrigger class uses an executorService for this cleanly,
without exposing anything else. Checking constantly for the remaining time seemed like an
overhead that would be cumulatively add to the runtime. 
    The one benefit of doing this in the Cursor would be that I could, potentially, have a
new QueryState defined as TIMED_OUT, but I'm reluctant to modify the Protobuf as of now.


> Drill JDBC driver support Statement.setQueryTimeout(int)
> --------------------------------------------------------
>
>                 Key: DRILL-3640
>                 URL: https://issues.apache.org/jira/browse/DRILL-3640
>             Project: Apache Drill
>          Issue Type: New Feature
>          Components: Client - JDBC
>    Affects Versions: 1.2.0
>            Reporter: Chun Chang
>            Assignee: Kunal Khatua
>             Fix For: 1.11.0
>
>
> It would be nice if we have this implemented. Run away queries can be automatically canceled
by setting the timeout. 
> java.sql.SQLFeatureNotSupportedException: Setting network timeout is not supported.
> 	at org.apache.drill.jdbc.impl.DrillStatementImpl.setQueryTimeout(DrillStatementImpl.java:152)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message