drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-3640) Drill JDBC driver support Statement.setQueryTimeout(int)
Date Wed, 21 Jun 2017 16:19:00 GMT

    [ https://issues.apache.org/jira/browse/DRILL-3640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16057773#comment-16057773
] 

ASF GitHub Bot commented on DRILL-3640:
---------------------------------------

Github user laurentgo commented on a diff in the pull request:

    https://github.com/apache/drill/pull/858#discussion_r123292200
  
    --- Diff: exec/jdbc/src/main/java/org/apache/drill/jdbc/SqlTimeoutException.java ---
    @@ -23,12 +23,17 @@
      * Indicates that an operation timed out. This is not an error; you can
      * retry the operation.
      */
    -public class SqlTimeoutException
    -    extends SQLException
    -{
    +public class SqlTimeoutException extends SQLException {
    +
    +  private static final long serialVersionUID = 2017_06_20L;
    --- End diff --
    
    maybe use -1  or use your IDE serialVersionUID generator (I know there's an algorithm
for it...), but I don't think Drill is making any effort to make this class serializable so
it could be a `@SuppressedWarning` annotation as well.


> Drill JDBC driver support Statement.setQueryTimeout(int)
> --------------------------------------------------------
>
>                 Key: DRILL-3640
>                 URL: https://issues.apache.org/jira/browse/DRILL-3640
>             Project: Apache Drill
>          Issue Type: New Feature
>          Components: Client - JDBC
>    Affects Versions: 1.2.0
>            Reporter: Chun Chang
>            Assignee: Kunal Khatua
>             Fix For: 1.11.0
>
>
> It would be nice if we have this implemented. Run away queries can be automatically canceled
by setting the timeout. 
> java.sql.SQLFeatureNotSupportedException: Setting network timeout is not supported.
> 	at org.apache.drill.jdbc.impl.DrillStatementImpl.setQueryTimeout(DrillStatementImpl.java:152)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message