drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-3640) Drill JDBC driver support Statement.setQueryTimeout(int)
Date Wed, 21 Jun 2017 16:19:00 GMT

    [ https://issues.apache.org/jira/browse/DRILL-3640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16057772#comment-16057772
] 

ASF GitHub Bot commented on DRILL-3640:
---------------------------------------

Github user laurentgo commented on a diff in the pull request:

    https://github.com/apache/drill/pull/858#discussion_r123294241
  
    --- Diff: exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillStatementImpl.java ---
    @@ -38,8 +44,12 @@
     // methods for compatibility.)
     class DrillStatementImpl extends AvaticaStatement implements DrillStatement,
                                                                  DrillRemoteStatement {
    +  //Not using the DrillbitContext's ExecutorService as this is threadPool is light-weight
(threads wake up to cancel tasks) but needs a low response time
    +  private static ExecutorService queryTimeoutTaskPool = Executors.newCachedThreadPool(new
NamedThreadFactory("q-timeout-"));
    --- End diff --
    
    I believe this is unnecessary: DrillClient provides an asynchronous API, which is used
by the JDBC driver, so all the timeout logic could be done without the use of thread pool.
You might want to look at DrillCursor which is where all the magic happens I believe.


> Drill JDBC driver support Statement.setQueryTimeout(int)
> --------------------------------------------------------
>
>                 Key: DRILL-3640
>                 URL: https://issues.apache.org/jira/browse/DRILL-3640
>             Project: Apache Drill
>          Issue Type: New Feature
>          Components: Client - JDBC
>    Affects Versions: 1.2.0
>            Reporter: Chun Chang
>            Assignee: Kunal Khatua
>             Fix For: 1.11.0
>
>
> It would be nice if we have this implemented. Run away queries can be automatically canceled
by setting the timeout. 
> java.sql.SQLFeatureNotSupportedException: Setting network timeout is not supported.
> 	at org.apache.drill.jdbc.impl.DrillStatementImpl.setQueryTimeout(DrillStatementImpl.java:152)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message