Mailing-List: contact issues-help@drill.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@drill.apache.org
Date: Tue, 9 May 2017 05:47:04 +0000 (UTC)
From: "Paul Rogers (JIRA)" <jira@apache.org>
To: issues@drill.apache.org
Message-ID: <JIRA.13070267.1494306725000.160484.1494308824198@Atlassian.JIRA>
In-Reply-To: <JIRA.13070267.1494306725000@Atlassian.JIRA>
References: <JIRA.13070267.1494306725000@Atlassian.JIRA> <JIRA.13070267.1494306725990@jira-lw-us.apache.org>
Subject: [jira] [Commented] (DRILL-5492) CSV reader does not validate header
 names, causes nonsense output
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 09 May 2017 05:47:25 -0000


    [ https://issues.apache.org/jira/browse/DRILL-5492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16002080#comment-16002080 ] 

Paul Rogers commented on DRILL-5492:
------------------------------------

Could not readily find a way to cause serious harm with this bug, so marked it as minor.

> CSV reader does not validate header names, causes nonsense output
> -----------------------------------------------------------------
>
>                 Key: DRILL-5492
>                 URL: https://issues.apache.org/jira/browse/DRILL-5492
>             Project: Apache Drill
>          Issue Type: Bug
>            Reporter: Paul Rogers
>            Priority: Minor
>
> Consider the same test case as in DRILL-5491, but with a slightly different input file:
> {code}
> ___
> a,b,c
> d,e,f
> {code}
> The underscores represent three spaces: use spaces in the real test.
> In this case, the code discussed in DRILL-5491 finds some characters and happily returns the following array:
> {code}
> ["   "]
> {code}
> The field name of three blanks is returned to the client to produce the following bizarre output:
> {code}
> 2 row(s):
>     
> a
> d
> {code}
> The blank line is normally the header, but the header here was considered to be three blanks. (In fact, the blanks are actually printed.)
> Since the blanks were considered to be a field, the file is assumed to have only one field, so only the first column was returned.
> The expected behavior is that spaces are trimmed from field names, so the field name list would be empty and a User Error thrown. (That is, it is confusing to the user why a blank line produces NPE, some produce the {{ExecutionSetupException}} shown in DRILL-5491, and some produce blank headings. Behavior should be consistent.


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)