Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 51C27200C7F for ; Wed, 24 May 2017 09:04:10 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 510B0160BD0; Wed, 24 May 2017 07:04:10 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 5F2D8160BDA for ; Wed, 24 May 2017 09:04:09 +0200 (CEST) Received: (qmail 71977 invoked by uid 500); 24 May 2017 07:04:08 -0000 Mailing-List: contact issues-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list issues@drill.apache.org Received: (qmail 71934 invoked by uid 99); 24 May 2017 07:04:08 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 24 May 2017 07:04:08 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 092F41AFCDF for ; Wed, 24 May 2017 07:04:08 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id 03hvRE55y2aB for ; Wed, 24 May 2017 07:04:07 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id BEA165FE1F for ; Wed, 24 May 2017 07:04:06 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id E0A9DE0DDA for ; Wed, 24 May 2017 07:04:05 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id C64B12408D for ; Wed, 24 May 2017 07:04:04 +0000 (UTC) Date: Wed, 24 May 2017 07:04:04 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@drill.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (DRILL-5485) Remove WebServer dependency on DrillClient MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 24 May 2017 07:04:10 -0000 [ https://issues.apache.org/jira/browse/DRILL-5485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16022416#comment-16022416 ] ASF GitHub Bot commented on DRILL-5485: --------------------------------------- Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/829#discussion_r118161022 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/QueryWrapper.java --- @@ -68,36 +53,49 @@ public String getQueryType() { return queryType; } - public UserBitShared.QueryType getType() { - UserBitShared.QueryType type = UserBitShared.QueryType.SQL; + public QueryType getType() { + QueryType type = QueryType.SQL; --- End diff -- Fixed. > Remove WebServer dependency on DrillClient > ------------------------------------------ > > Key: DRILL-5485 > URL: https://issues.apache.org/jira/browse/DRILL-5485 > Project: Apache Drill > Issue Type: Improvement > Components: Web Server > Reporter: Sorabh Hamirwasia > Fix For: 1.11.0 > > > With encryption support using SASL, client's won't be able to authenticate using PLAIN mechanism when encryption is enabled on the cluster. Today WebServer which is embedded inside Drillbit creates a DrillClient instance for each WebClient session. And the WebUser is authenticated as part of authentication between DrillClient instance and Drillbit using PLAIN mechanism. But with encryption enabled this will fail since encryption doesn't support authentication using PLAN mechanism, hence no WebClient can connect to a Drillbit. There are below issues as well with this approach: > 1) Since DrillClient is used per WebUser session this is expensive as it has heavyweight RPC layer for DrillClient and all it's dependencies. > 2) If the Foreman for a WebUser is also selected to be a different node then there will be extra hop of transferring data back to WebClient. > To resolve all the above issue it would be better to authenticate the WebUser locally using the Drillbit on which WebServer is running without creating DrillClient instance. We can use the local PAMAuthenticator to authenticate the user. After authentication is successful the local Drillbit can also serve as the Foreman for all the queries submitted by WebUser. This can be achieved by submitting the query to the local Drillbit Foreman work queue. This will also remove the requirement to encrypt the channel opened between WebServer (DrillClient) and selected Drillbit since with this approach there won't be any physical channel opened between them. -- This message was sent by Atlassian JIRA (v6.3.15#6346)