Mailing-List: contact issues-help@drill.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@drill.apache.org
Date: Thu, 11 May 2017 22:33:04 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@drill.apache.org
Message-ID: <JIRA.13069614.1494026563000.192592.1494541984413@Atlassian.JIRA>
In-Reply-To: <JIRA.13069614.1494026563000@Atlassian.JIRA>
References: <JIRA.13069614.1494026563000@Atlassian.JIRA> <JIRA.13069614.1494026563079@jira-lw-us.apache.org>
Subject: [jira] [Commented] (DRILL-5481) Allow Drill to persist profiles
 in-memory only with a max capacity
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Thu, 11 May 2017 22:33:15 -0000


    [ https://issues.apache.org/jira/browse/DRILL-5481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16007313#comment-16007313 ] 

ASF GitHub Bot commented on DRILL-5481:
---------------------------------------

Github user sudheeshkatkam commented on a diff in the pull request:

    https://github.com/apache/drill/pull/827#discussion_r116116596
  
    --- Diff: exec/java-exec/src/main/resources/drill-module.conf ---
    @@ -138,7 +138,10 @@ drill.exec: {
         class: "org.apache.drill.exec.store.sys.store.provider.ZookeeperPersistentStoreProvider",
         local: {
           path: "/tmp/drill",
    -      write: true
    +      inmemory: {
    +        write: false,
    +        capacity: 1000
    --- End diff --
    
    Remove this line, otherwise `if (config.hasPath(ExecConstants.SYS_STORE_CAPACITY_PROFILES))` is always true.


> Allow Drill to persist profiles in-memory only with a max capacity
> ------------------------------------------------------------------
>
>                 Key: DRILL-5481
>                 URL: https://issues.apache.org/jira/browse/DRILL-5481
>             Project: Apache Drill
>          Issue Type: Improvement
>    Affects Versions: 1.10.0
>            Reporter: Kunal Khatua
>            Assignee: Kunal Khatua
>
> To allow for fast persistence of profiles on a temporary basis (i.e. till the life of the Drillbit), an existing test class {{org.apache.drill.exec.testing.store.NoWriteLocalStore.java}} was refactored to {{org.apache.drill.exec.store.sys.store.EphemeralPersistentStore}} and given the ability to maintain a max capacity.
> This should allow query profiles to be available for as long as the Drillbit process' lifespan.


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)